Skip to content

docs: translate You Might Not Need An Effect - #362

Closed
averrows wants to merge 6 commits into
reactjs:mainfrom
averrows:main
Closed

docs: translate You Might Not Need An Effect#362
averrows wants to merge 6 commits into
reactjs:mainfrom
averrows:main

Conversation

@averrows

@averrowsaverrows commented Apr 27, 2023•
edited by zainfathoni
Loading

Copy link
Copy Markdown

Bahasa translation for Escape Hatches > You might not need an effect.

Issue: #330

Closes#390

mhaidarhanif
mhaidarhanif requested changes Apr 27, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussions and suggestions to consider.

Comment threadsrc/content/learn/escape-hatches.md Outdated
Comment threadsrc/content/learn/escape-hatches.md Outdated
Comment threadsrc/content/learn/escape-hatches.md Outdated
mhaidarhanif
mhaidarhanif requested changes Apr 27, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to avoid translating the variable and function names.

cc @resir014@r17x@mazipan@zainfathoni

Comment threadsrc/content/learn/escape-hatches.md Outdated
Comment threadsrc/content/learn/escape-hatches.md Outdated
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment
@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions

github-actionsBot commented Apr 28, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@reactjsreactjs deleted a comment from vercelBotApr 28, 2023
@mhaidarhanif
mhaidarhanif marked this pull request as draft April 28, 2023 15:12
@mhaidarhanif

mhaidarhanif commented Apr 28, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

@averrows Converted back to draft because starting from "Lifecycle of reactive effects" it's not been translated yet.

@resir014

resir014 commented Jun 13, 2023

Copy link
Copy Markdown
Member

@averrows Hello, any progress on the remaining untranslated content? If we don't hear from you within 24-48 hours, we're going to reassign this PR to someone else.

@resir014resir014 changed the title New Indonesian Translation: Escape Hatches > You might not need an effectdocs: translate You Might Not Need An EffectJun 13, 2023
@averrows

averrows commented Jun 14, 2023

Copy link
Copy Markdown
Author

Hi @resir014, per my understanding, "Lifecycle of reactive effects" and parts after that are on different issues ex: #391. And my translation of "You Might Not Need an Effect" is all done and I had applied the reviews. Or do I understand it wrong?

@mhaidarhanif

mhaidarhanif commented Jun 14, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Wait, that's why it's confusing because it should not translate only one section of the page. All translation PRs need to translate one whole page.

@averrows This connected PR should translate the whole page of "You Might Not Need an Effect": https://id.react.dev/learn/you-might-not-need-an-effect

That issue is for that whole page. My recommendation would be fixing this by translating the intended page of "You Might Not Need an Effect", not the "Escape hatches" because it's been translated here: #522

So there's actually a misunderstanding of translating the page.

Check again from the issue list:

image

Check again from the initial issue and link to the page:

image

cc @resir014@mazipan@zainfathoni@r17x

@resir014

resir014 commented Jun 26, 2023

Copy link
Copy Markdown
Member

Yes, as @mhaidarhanif mentioned above. If you're unable to do it, then we can reassign this PR to someone else. @averrows

@github-actions

github-actionsBot commented Jul 16, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014resir014 closed this Apr 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zainfathonizainfathonizainfathoni left review comments
@mazipanmazipanmazipan left review comments
@mhaidarhanifmhaidarhanifAwaiting requested review from mhaidarhanif
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

You Might Not Need an Effect

5 participants

@averrows@mhaidarhanif@resir014@zainfathoni@mazipan