Skip to content

docs: translate introduction of escape hatches - #522

Merged
mhaidarhanif merged 18 commits into
reactjs:mainfrom
eriansha:docs/translation/escape-hatches
Nov 4, 2023
Merged

docs: translate introduction of escape hatches#522
mhaidarhanif merged 18 commits into
reactjs:mainfrom
eriansha:docs/translation/escape-hatches

Conversation

@eriansha

@erianshaeriansha commented May 1, 2023

Copy link
Copy Markdown
Contributor

Closes#386

Description

Translate the escape hatches page.
Page URL: https://react.dev/learn/escape-hatches

@erianshaeriansha changed the title docs: translate introduction of escape hatchesDocs: translate introduction of escape hatchesMay 1, 2023
@mhaidarhanifmhaidarhanif mentioned this pull request Jun 14, 2023
Closed
@eriansha
erianshaforce-pushed the docs/translation/escape-hatches branch from 6f2180f to ff9fbb6CompareJuly 9, 2023 07:25
@github-actions

github-actionsBot commented Jul 9, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

PageSize (compressed)First Load
/[[...markdownPath]]79.25 KB(🟡 +3 B)183.2 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@eriansha
eriansha marked this pull request as ready for review October 21, 2023 15:36
@eriansha
erianshaforce-pushed the docs/translation/escape-hatches branch from c27134e to cecad42CompareOctober 21, 2023 15:37
resir014
resir014 reviewed Oct 24, 2023
View reviewed changes

@resir014resir014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor non-blocking change required. Please check them out. @eriansha

Comment threadsrc/content/learn/escape-hatches.md Outdated
@eriansha@resir014
doc: Change 'menekan' to 'tekan'
a33ff80
Co-authored-by: Resi Respati <resir014@gmail.com>
@resir014resir014 changed the title Docs: translate introduction of escape hatchesdocs: translate introduction of escape hatchesOct 29, 2023
mhaidarhanif
mhaidarhanif requested changes Oct 29, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements

Comment threadsrc/content/learn/escape-hatches.md Outdated
Comment threadsrc/content/learn/escape-hatches.md Outdated
Comment threadsrc/content/learn/escape-hatches.md Outdated
@resir014

resir014 commented Nov 3, 2023

Copy link
Copy Markdown
Member

Hi @eriansha, do you have time to make the requested changes?

@eriansha

eriansha commented Nov 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @eriansha, do you have time to make the requested changes?

sure, sorry for delayed response.
i might create the changes on tommorrow 🙇🏻‍♂️

@eriansha@mhaidarhanif
fix: italicized english translation on link
8a38389
Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
erianshaand others added 2 commits November 4, 2023 00:11
@eriansha@mhaidarhanif
docs: adapt translation with origin phrase
5b86a33
Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
@eriansha@mhaidarhanif
fix: typo 'pembersihan'
153e4aa
Co-authored-by: M Haidar Hanif <me@mhaidarhanif.com>
@eriansha

eriansha commented Nov 3, 2023

Copy link
Copy Markdown
ContributorAuthor

resolving @mhaidarhanif's comment. thank you to check small detail that i missed out 😄

mhaidarhanif
mhaidarhanif approved these changes Nov 4, 2023
View reviewed changes

@mhaidarhanifmhaidarhanif left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriansha You're welcome

@mhaidarhanif
mhaidarhanif merged commit f52bcd9 into reactjs:mainNov 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resir014resir014resir014 left review comments
@mhaidarhanifmhaidarhanifmhaidarhanif approved these changes
@zainfathonizainfathoniAwaiting requested review from zainfathoni
@mazipanmazipanAwaiting requested review from mazipan
@r17xr17xAwaiting requested review from r17x

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escape Hatches

3 participants

@eriansha@resir014@mhaidarhanif