Translate Refs and the DOM by y-temp4 · Pull Request #52 · reactjs/ja.react.dev

y-temp4 · 2019-02-03T05:17:58Z

This PR is a part of #4.

y-temp4 · 2019-02-03T14:13:29Z

assign @smikitky as a reviewer

ですが、変更できなかったため、No reviews となっています。
レビューをお願いします🙏

sasurau4 · 2019-02-05T03:04:57Z

レビューします 👍

sasurau4

翻訳ありがとうございます 👍
結構、コメントしましたので確認お願いします 🙏

sasurau4 · 2019-02-05T04:37:36Z

+上記の例では、`Parent` は ref コールバックを `inputRef` prop として `CustomTextInput` に渡し、`CustomTextInput` は同じ関数を特別な `ref` 属性として `<input>` に渡します。 その結果、`Parent` の `this.inputElement` は、`CustomTextInput` の `<input>` 要素に対応する DOM ノードに設定されます。

-### Legacy API: String Refs
+### レガシー API：String Refs


Suggested change
### レガシー API：String Refs
### レガシー API：文字列 Refs

String 訳さなくてもいいかも 🤔

個人的には訳さなくても良いかと思います！

y-temp4 · 2019-02-05T04:49:20Z

@sasurau4 レビューありがとうございます！
後ほど確認させていただきます🙏

Co-Authored-By: y-temp4 <y.temp4@gmail.com>

y-temp4 · 2019-02-05T13:07:44Z

@sasurau4 #52 (comment) と #52 (comment) 以外は一旦変更を取り入れさせていただきました！
丁寧なご指摘、ありがとうございました😄

smikitky · 2019-02-05T17:05:37Z

1つ1つの修正で全部コミットを作るのは大変なのでバッチコミットの機能を使ってください。"Files Changed"のタブの方で使えます。

あと key とかもそうですが、見出しなどで refs となっていたとしても、 ref は単体で使うので基本単数形で訳してください。(props は prop の塊なので props ですが）

y-temp4 · 2019-02-06T00:53:48Z

@smikitky 承知しました🙇‍♂️
refs に関して修正させていただきます🙏

y-temp4 · 2019-02-06T01:31:13Z

@smikitky refs に関して、修正させていただきました🙏

koba04 · 2019-02-06T11:10:03Z

@y-temp4 タイトル部分などまだRefsの表記が残っているようなので確認お願いします 🙏

y-temp4 · 2019-02-07T01:35:54Z

@koba04 一通り Refs を Ref に変更したので、確認をお願いします🙏

smikitky

軽微なものばかりですが、確認しましたのでいくつか対応をお願いします。

Co-Authored-By: y-temp4 <y.temp4@gmail.com>

y-temp4 · 2019-02-07T02:26:23Z

@smikitky 修正させていただきました！
ご指摘ありがとうございました🙏

koba04

@y-temp4 細かい点をいくつかコメントしましたので確認お願いします 🙇

Co-Authored-By: y-temp4 <y.temp4@gmail.com>

y-temp4 · 2019-02-08T00:42:11Z

@koba04 変更を反映させていただきました！
ご指摘ありがとうございます🙏

koba04 · 2019-02-08T06:40:29Z

@y-temp4 ありがとうございます、mergeしました！！ 👏👏👏

smikitky · 2019-02-08T06:47:02Z

@y-temp4 ありがとうございました！

@koba04 #96 が進行中なので、個別記事のマージよりそちらを先にした方が幸せかもしれません。これは個別に対処します。

doc: Translate Refs and the DOM
72b2e74

smikitky self-requested a review February 4, 2019 00:50

koba04 requested review from koba04 and removed request for koba04 February 4, 2019 01:17

tesseralis mentioned this pull request Feb 5, 2019
Japanese Translation Progress #4
Closed
90 tasks

sasurau4 suggested changes Feb 5, 2019
View reviewed changes

sasurau4and others added 21 commits February 5, 2019 21:41

Update content/docs/refs-and-the-dom.md
6b37062
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
dcbff65
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
248c894
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
93834c8
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
e01c265
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
5e13d8c
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
2d0d2aa
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

doc: Remove useless space
d3d0c48

Update content/docs/refs-and-the-dom.md
7a3d828
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
61def37
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
b59152d
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
5c8c172
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

doc: Remove useless space
e6c397c

Update content/docs/refs-and-the-dom.md
ec7f289
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
770c934
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
8b5b402
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
9912ddc
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
f96ab8f
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
976ff03
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
a13fd52
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
7b7b334
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

sasurau4and others added 7 commits February 5, 2019 21:58

Update content/docs/refs-and-the-dom.md
f696db2
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
622a850
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

Update content/docs/refs-and-the-dom.md
ffcb4f6
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

doc: Remove useless space
943df24

Update content/docs/refs-and-the-dom.md
82e3a49
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

doc: Remove useless space
401f6c5

Update content/docs/refs-and-the-dom.md
f755325
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

doc: Change "refs" to "ref"
df4c0f4

koba04 mentioned this pull request Feb 6, 2019
Use singular 'ref' and 'key' #66
Merged

doc: Change "refs" to "ref"
740d9a2

smikitky requested changes Feb 7, 2019
View reviewed changes

smikitkyand others added 2 commits February 7, 2019 11:23

Apply suggestions from code review
a4a8c02
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

doc: Remove useless line break
7402602

smikitky approved these changes Feb 7, 2019
View reviewed changes

koba04 requested changes Feb 7, 2019
View reviewed changes

Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated
Comment threadcontent/docs/refs-and-the-dom.md Outdated

Apply suggestions from code review
1a4941c
Co-Authored-By: y-temp4 <y.temp4@gmail.com>

koba04 approved these changes Feb 8, 2019
View reviewed changes

koba04 merged commit aff8f2f into reactjs:masterFeb 8, 2019

smikitky mentioned this pull request Feb 8, 2019
Add custom ids to refs-and-dom #97
Closed

	### レガシー API：String Refs
	### レガシー API：文字列 Refs

Uh oh!

Conversation

y-temp4 commented Feb 3, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

y-temp4 commented Feb 3, 2019

Uh oh!

sasurau4 commented Feb 5, 2019

Uh oh!

sasurau4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sasurau4Feb 5, 2019

Choose a reason for hiding this comment

Uh oh!

sasurau4Feb 5, 2019

Choose a reason for hiding this comment

Uh oh!

y-temp4Feb 5, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

y-temp4 commented Feb 5, 2019

Uh oh!

y-temp4 commented Feb 5, 2019

Uh oh!

smikitky commented Feb 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

y-temp4 commented Feb 6, 2019

Uh oh!

y-temp4 commented Feb 6, 2019

Uh oh!

koba04 commented Feb 6, 2019

Uh oh!

y-temp4 commented Feb 7, 2019

Uh oh!

smikitky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

y-temp4 commented Feb 7, 2019

Uh oh!

koba04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

y-temp4 commented Feb 8, 2019

Uh oh!

koba04 commented Feb 8, 2019

Uh oh!

smikitky commented Feb 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

y-temp4 commented Feb 3, 2019•
edited
Loading

smikitky commented Feb 5, 2019•
edited
Loading