Skip to content

Add original English explicit heading IDs to everything - #96

Merged
tesseralis merged 19 commits into
masterfrom
sync-original
Feb 8, 2019
Merged

Add original English explicit heading IDs to everything#96
tesseralis merged 19 commits into
masterfrom
sync-original

Conversation

@tesseralis

Copy link
Copy Markdown
Contributor

@smikitky since I was the one who didn't figure this out until late I figured it was my responsibility to fix it :P

@tesseralistesseralis changed the title Add original English headings to everythingAdd original English explicit heading IDs to everythingFeb 8, 2019
@tesseralis

Copy link
Copy Markdown
ContributorAuthor

@smikitky thanks for finding all those errors >_< How are you able to find them? Whenever I try to look at the diff on github everything just freezes up!

@smikitky

Copy link
Copy Markdown
Member

Oh, thank you. Did you use some script to do this?

I removed one conflict and one punctuation error.

Textlint is complaining because we expect fullwidth space after a fullwidth exclamation mark:

## 始めましょう! {#lets-get-started}
^

But I believe this is an error on the textlint's side. We may have to disable this rule temporarily because this should be merged promptly. @potato4d@koba04 What do you think?

@smikitky

Copy link
Copy Markdown
Member

@tesseralis I'm using vscode-pull-request to check the diff on my PC!

@tesseralis

Copy link
Copy Markdown
ContributorAuthor

I did use some script to do it 😛

Also I should check vscode-pull-request! Thanks for being on top of this as always 🙏

@smikitky

smikitky commented Feb 8, 2019

Copy link
Copy Markdown
Member

I took the liberty to disable the two textlint rules that were causing trouble. IMHO, these rules have not been working correctly anyway, and we should introduce our own rule. (#20)

@tesseralis

Copy link
Copy Markdown
ContributorAuthor

@smikitky It's very important that we don't do a squash commit here or else git won't register the original commits and doing another sync will cause errors.

@potato4d

Copy link
Copy Markdown
Contributor

@smikitky

But I believe this is an error on the textlint's side. We may have to disable this rule temporarily because this should be merged promptly. @potato4d@koba04 What do you think?

I think there is no problem.

@smikitkysmikitky mentioned this pull request Feb 8, 2019
@smikitkysmikitky mentioned this pull request Feb 8, 2019

@koba04koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tesseralis
tesseralis merged commit 8644395 into masterFeb 8, 2019
@smikitkysmikitky mentioned this pull request Feb 8, 2019
90 tasks
@potato4d
potato4d deleted the sync-original branch February 20, 2019 03:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tesseralis@smikitky@potato4d@koba04@reactjs-translation-bot