Skip to content

Feat/hooks faq translation - #115

Merged
glaucia86 merged 25 commits into
reactjs:masterfrom
frontendwizard:feat/hooks-faq-translation
Mar 3, 2019
Merged

Feat/hooks faq translation#115
glaucia86 merged 25 commits into
reactjs:masterfrom
frontendwizard:feat/hooks-faq-translation

Conversation

@frontendwizard

@frontendwizardfrontendwizard commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

Please, note that this is pretty much unreviewed translation, so it's likely to have typos and some incorrect translations that diverge from the glossary. I'll review this tomorrow and fix all the issues that I can find. That said, if anyone wishes to review it too, here it is. I'll mark this as a draft PR till I review it.

@netlify

netlifyBot commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit 59e8bad

https://deploy-preview-115--pt-br-reactjs.netlify.com

@tibuurciotibuurcio added needs review A pull request ready to be reviewed 💪 long page - more than 100 lines Long page labels Feb 20, 2019
Rahmon
Rahmon reviewed Feb 20, 2019
View reviewed changes
Comment threadcontent/docs/hooks-faq.md Outdated
Luanf
Luanf reviewed Feb 21, 2019
View reviewed changes
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
@frontendwizard
frontendwizard marked this pull request as ready for review February 21, 2019 12:35
@tesseralistesseralis mentioned this pull request Feb 21, 2019
Closed
90 tasks
@halian-vilelahalian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
Luanf
Luanf suggested changes Feb 21, 2019
View reviewed changes
Comment threadcontent/docs/hooks-faq.md Outdated
@frontendwizard

frontendwizard commented Feb 26, 2019

Copy link
Copy Markdown
ContributorAuthor

Mais alguma coisa galera? Todos os erros apontados foram corrigidos.

jhonmike
jhonmike requested changes Feb 27, 2019
View reviewed changes

@jhonmikejhonmike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Então comentei sobre o uso do Hook custom em um dos comentários acima, acho legal verificar todos no arquivo e tentar traduzir para Hooks customizados|personalizados.

Faltou revisar o finalzinho, assim que possível faço o resto da review

Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
@halian-vilelahalian-vilela added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 27, 2019
@halian-vilelahalian-vilela self-assigned this Feb 27, 2019
@halian-vilela

halian-vilela commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Legal galera, acho que as principais dúvidas estão resolvidas.

@thefrontendwizard pode fazer os últimos ajustes aí.

@Luanf e @jhonmike assim que ele fizer podem aprovar os reviews que a gente aprova a PR!

Valeu!

jhonmike
jhonmike requested changes Feb 27, 2019
View reviewed changes
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Jhon Mikeand others added 3 commits February 27, 2019 13:51
Jhon Mikethefrontendwizard
Fix typo
b93e88c
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Remove duplicated line
c36e6ed
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Fix grammar issues
565123a
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikeand others added 6 commits February 27, 2019 13:52
Jhon Mikethefrontendwizard
Change 'custom' to 'customizados'
50b3b23
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Improve grammar
81b2487
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Improve grammar
ee135e0
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Update content/docs/hooks-faq.md
148c47c
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Remove duplicated word
dc1dbc6
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
Jhon Mikethefrontendwizard
Fix grammar issues
39c66ac
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
@frontendwizard

frontendwizard commented Feb 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Valeu pela review galera. Vou corrigir os últimos problemas relacionados a HOC aqui e já atualizo a PR.

@frontendwizard

frontendwizard commented Feb 27, 2019

Copy link
Copy Markdown
ContributorAuthor

There we go. Correções feitas.

Luanf
Luanf previously approved these changes Feb 27, 2019
View reviewed changes

@LuanfLuanf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Parece bão pra mim" 👍

jhonmike
jhonmike requested changes Feb 28, 2019
View reviewed changes

@jhonmikejhonmike left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ainda tem vários Hook custom, não vou comentar em todos, acho q um ctrl+f resolve ae para encontrar hehe

Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Comment threadcontent/docs/hooks-faq.md Outdated
Jhon Mikethefrontendwizard
Change custom to customizados
d77c345
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
@frontendwizard
frontendwizard dismissed stale reviews from Luanf via d77c345February 28, 2019 14:21
@frontendwizard

frontendwizard commented Feb 28, 2019

Copy link
Copy Markdown
ContributorAuthor

Ok, agora os problemas com custom foram resolvidos. Mudei para customizado/customizados aonde era necessário.

jhonmike
jhonmike approved these changes Feb 28, 2019
View reviewed changes

@jhonmikejhonmike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

glaucia86
glaucia86 approved these changes Mar 3, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefrontendwizard Parabéns! A sua contribuição foi aprovada!
Agradecemos e muito pela sua excelente contribuição!

LGTM 👍

@glaucia86
glaucia86 merged commit 515a4c0 into reactjs:masterMar 3, 2019
@glaucia86glaucia86 added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input 💪 long page - more than 100 lines Long page labels Mar 3, 2019
@frontendwizard
frontendwizard deleted the feat/hooks-faq-translation branch March 5, 2019 15:52
@tibuurciotibuurcio mentioned this pull request Mar 7, 2019
Closed
13 tasks
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
Juliano Rafael@glaucia86
Feat/hooks faq translation (reactjs#115)
7933aa9
* Translate Adoption Strategy section of Hooks FAQ
* Update toc on Hooks FAQ
* Translate From Classes to Hooks section of Hooks FAQ
* Translate Performance Optimizations section of Hooks FAQ
* Translate Under the Hood section from Hooks FAQ
* Update Hooks FAQ TOC
* Fix translation mistakes on Hooks FAQ
* Review changes
* Review fixes
* Fix typo
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Remove duplicated line
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Fix grammar issues
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Change 'custom' to 'customizados'
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Improve grammar
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Improve grammar
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Update content/docs/hooks-faq.md
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Remove duplicated word
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Fix grammar issues
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Normalize translation of HOC
* Remove duplicated line
* Change custom to customizados
Co-Authored-By: thefrontendwizard <julianorsfarias@msn.com>
* Change remaining custom to customizado
* Fix unwanted line break.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike approved these changes
+4 more reviewers
@halian-vilelahalian-vilelahalian-vilela left review comments
@RahmonRahmonRahmon left review comments
@glaucia86glaucia86glaucia86 approved these changes
@LuanfLuanfLuanf left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@halian-vilelahalian-vilela

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@frontendwizard@halian-vilela@glaucia86@jhonmike@Rahmon@Luanf@tibuurcio