Skip to content

Translating Implementation Notes - #146

Merged
glaucia86 merged 13 commits into
reactjs:masterfrom
Luanf:implementation-notes-pt-br
Mar 9, 2019
Merged

Translating Implementation Notes#146
glaucia86 merged 13 commits into
reactjs:masterfrom
Luanf:implementation-notes-pt-br

Conversation

@Luanf

@LuanfLuanf commented Mar 7, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

OK - Esse arquivo é longo e denso.
Detalhes de implementação do React é um tema pouco discutido então vários termos acabaram aparecendo pela primeira vez aqui, fiz um esforço para traduzir ao português a maior parte dos termos novos mesmo que cause um certo estranhamento a principio. No entanto fica aberto a discussão aqui se faz sentido remover a tradução de alguns termos e usar o original.

Um compilado de alguns termos que traduzi:

  • Stack reconciler -> Reconciliador de pilha
  • Fiber reconciler -> Reconciliador de fibra
  • Host component -> Componente hospedeiro
  • Composite component -> Componente composto
  • Lifecycle Method -> Método do ciclo de vida (acredito que esse termo deva aparecer em outros textos, mas ano esta no glossário)
  • Mount -> Tentei manipular o substantivo "Montagem" para encaixar nas frases
  • Unmount -> Mesma coisa com "Desmontagem"
  • Internal instance -> Instância interna
  • Public instance -> Instância publica

E provavelmente mais alguns... Na medida que for decidido algumas traduções eu adicionarei elas ao Glossário.

Tenho certeza que em um texto longo assim deixei passar coisas e há o que melhorar, então aprecio os reviews 😁

PS: Tem alguns commits "Apply suggestions from code review" na minha branch pois usei a própria ferramenta de suggestions pra revisar minha tradução em um "PR simulado" no meu próprio fork. Achei prático e recomendo 👍

@LuanfLuanf mentioned this pull request Mar 7, 2019
Closed
13 tasks
@netlify

netlifyBot commented Mar 7, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit 547a52d

https://deploy-preview-146--pt-br-reactjs.netlify.com

@jhonmikejhonmike added the needs review A pull request ready to be reviewed label Mar 7, 2019
@tesseralistesseralis mentioned this pull request Mar 7, 2019
Closed
90 tasks
eduardomoroni
eduardomoroni suggested changes Mar 7, 2019
View reviewed changes

@eduardomoronieduardomoroni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Luanf show de bola a tradução, fiz alguns comentarios. Tu poderia dar uma olhada e ver o que tu acha?

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
@eduardomoronieduardomoroni added needs +1 Needs another approval before merging 💪 long page - more than 100 lines Long page and removed needs review A pull request ready to be reviewed labels Mar 7, 2019
@eduardomoronieduardomoroni self-assigned this Mar 7, 2019
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
@Luanf
Apply suggestions from code review
8bbd89d
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
@Luanf

Luanf commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

Obrigado pelo review @eduardomoroni !
Fiz algumas das suas correções rápidas mas ainda vou rever alguns comentários com calma.
Se mais alguém quiser opinar nas questões levantadas, fico grato

Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
@Luanf
Apply suggestions from code review
c2ee10a
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 7, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
@Luanf

Luanf commented Mar 7, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Trabalhei nas questões apontadas.
Infelizmente tentei um jeito diferente de alterar aqui pela pagina mas acabou gerando um pouco de poluição nas mensagens acima.
Da próxima vez faço do bom e velho jeito tradicional mesmo.
Fico no aguardo de mais comentários e revisões!

lucianomlima
lucianomlima reviewed Mar 7, 2019
View reviewed changes

@lucianomlimalucianomlima left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me perdoe pelo enorme review, mas sugeri várias mudanças para deixar a leitura mais fácil.
Tem algumas correções de acentuação também.

Uma coisa que não pude colocar nesse review foi a mudança do title no início do arquivo.
Mude para Notas de Implementação para aparecer traduzido ao ser compilado para o site.
Bom trabalho!

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Luanf
Luanf commented Mar 8, 2019
View reviewed changes
Comment threadcontent/docs/implementation-notes.md Outdated
@lucianomlima

lucianomlima commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

Esse documento é enorme. Se já me deu trabalho revisar, imagine traduzir. Parabéns man! Falta pouco! 🎉

@Luanf
Apply suggestions from code review
32ba787
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
@Luanf

Luanf commented Mar 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Opa, obrigadão pelo ótimo review 😊
Vários pontos legais que tu viu e levantou.
Corrigi vários mas falta alguns pontinhos que estarei mexendo em brevíssimo.
Deixei alguns poucos comentários para mais discussão também 👍

@lucianomlima

lucianomlima commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

Opa, obrigadão pelo ótimo review 😊
Vários pontos legais que tu viu e levantou.
Corrigi vários mas falta alguns pontinhos que estarei mexendo em brevíssimo.
Deixei alguns poucos comentários para mais discussão também 👍

Por nada! Marca os que você já mudou depois como resolved e não esquece de traduzir o title na linha 3. Good Job!

@eduardomoroni

eduardomoroni commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

@Luanf
Além do titulo, falta algo ainda?
image

@eduardomoronieduardomoroni added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Mar 9, 2019
@Luanf

Luanf commented Mar 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Vou fazer a correção final agora! =)

lucianomlimaand others added 2 commits March 9, 2019 08:04
@Luanf

Luanf commented Mar 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Os últimos 2 commits devem possuir as correções pendentes. 🔎

eduardomoroni
eduardomoroni approved these changes Mar 9, 2019
View reviewed changes

@eduardomoronieduardomoroni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belissimo trabalho @Luanf, tradução complicadinha aqui.
Assim que @lucianomlima ou alguém mais aprovar a gente mergeia.

@eduardomoronieduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Mar 9, 2019
glaucia86
glaucia86 approved these changes Mar 9, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86

glaucia86 commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

bitmoji

@Luanf muito obrigada pela sua excelente contribuição. Estou aprovando a sua contribuição e realizando o merge para a master! Mais uma vez muito obrigada :)

@glaucia86
glaucia86 merged commit 4eeba00 into reactjs:masterMar 9, 2019
@glaucia86glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed 💪 long page - more than 100 lines Long page labels Mar 9, 2019
@Luanf

Luanf commented Mar 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Obrigado pessoal! 🙏

devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@Luanf@glaucia86
Translating Implementation Notes (reactjs#146)
87cc7a7
* WiP - Translating Implementation Notes
* WiP - Almost finished first pass of the whole document
* WiP - Add comments and recheck grammar.
* Apply suggestions from code review
* Apply suggestions from code review [2]
* Apply suggestions from code review [3]
* Apply suggestions from code review [4]
* Apply suggestions from code review
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
* Apply suggestions from code review
* Apply suggestions from code review
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
* Apply suggestions from code review
Co-Authored-By: Luanf <luanegidioferreira@gmail.com>
* Translate title and a few considerations
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@lucianomlimalucianomlimalucianomlima left review comments
@eduardomoronieduardomoronieduardomoroni approved these changes
@glaucia86glaucia86glaucia86 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eduardomoronieduardomoroni

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Luanf@lucianomlima@eduardomoroni@glaucia86@jhonmike