Skip to content

DOM Virtual e Objetos Internos - #159

Merged
jhonmike merged 8 commits into
reactjs:masterfrom
WeslleyNasRocha:virtual-dom-and-internals
Mar 15, 2019
Merged

DOM Virtual e Objetos Internos#159
jhonmike merged 8 commits into
reactjs:masterfrom
WeslleyNasRocha:virtual-dom-and-internals

Conversation

@WeslleyNasRocha

@WeslleyNasRochaWeslleyNasRocha commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@WeslleyNasRochaWeslleyNasRocha mentioned this pull request Mar 11, 2019
Closed
90 tasks
@netlify

netlifyBot commented Mar 11, 2019

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit a4c1713

https://deploy-preview-159--pt-br-reactjs.netlify.com

@netlify

netlifyBot commented Mar 11, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit 3fbf7ea

https://deploy-preview-159--pt-br-reactjs.netlify.com

jhonmike
jhonmike reviewed Mar 11, 2019
View reviewed changes

@jhonmikejhonmike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefiro Virtual DOM do que DOM Virtual, nunca vi ninguém traduzir esse termo.

Comment threadcontent/docs/faq-internals.md Outdated
@jhonmike

jhonmike commented Mar 11, 2019

Copy link
Copy Markdown
Member

mandei algumas considerações na review, aguardo sua resposta, e logo em seguida podemos dar merge, no mais acho q ficou ótimo!

@jhonmikejhonmike added needs review A pull request ready to be reviewed needs author response Changes requested needing author's input labels Mar 11, 2019
@tibuurciotibuurcio mentioned this pull request Mar 11, 2019
Closed
13 tasks
@jhonmikejhonmike added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Mar 11, 2019
jhonmike
jhonmike previously approved these changes Mar 11, 2019
View reviewed changes

@jhonmikejhonmike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

halian-vilela
halian-vilela suggested changes Mar 13, 2019
View reviewed changes

@halian-vilelahalian-vilela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeslleyNasRocha

Grande Weslley!

Fiz só algumas pequenas sugestões para manter a proximidade com o texto original ou deixar alguns conceitos mais precisos.

Dê uma olhada anos ajustes propostos e já aprovaremos sua contribuição!

Muito obrigado!

Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
Comment threadcontent/docs/faq-internals.md Outdated
@halian-vilelahalian-vilela added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Mar 13, 2019
@jhonmike
jhonmike self-requested a review March 13, 2019 02:34
@halian-vilela@WeslleyNasRocha
Apply suggestions from code review
baf4861
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@WeslleyNasRocha
WeslleyNasRocha dismissed stale reviews from jhonmike via baf4861March 13, 2019 12:49
jhonmike
jhonmike requested changes Mar 15, 2019
View reviewed changes

@jhonmikejhonmike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faltou apenas esse item aqui:

Comment threadcontent/docs/faq-internals.md Outdated
Jhon Mike@WeslleyNasRocha
Update content/docs/faq-internals.md
3fbf7ea
opa
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@jhonmike
jhonmike merged commit 7799fb8 into reactjs:masterMar 15, 2019
@jhonmikejhonmike added the 🌐 translated Translation is completed for this page label Mar 15, 2019
@jhonmikejhonmike removed the needs author response Changes requested needing author's input label Mar 15, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@WeslleyNasRochaJhon Mike
DOM Virtual e Objetos Internos (reactjs#159)
f4e07e2
* first version
* fix
* virtual dom
* handling
* Apply suggestions from code review
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
* Update faq-internals.md
* Update content/docs/faq-internals.md
opa
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike approved these changes
+1 more reviewer
@halian-vilelahalian-vilelahalian-vilela requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WeslleyNasRocha@jhonmike@halian-vilela