Uh oh!
There was an error while loading. Please reload this page.
Get tests passing - #1114
Conversation
Main purpose is to update mimemagic as the version in the lock file was yanked from Rubygems.
d887a4b to
74a3830CompareChrome addon requires >= xenial
* Add Ruby 3.0 * Add Rails 5.2/Webpacker 5
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs#1114.
justin808
commented
Aug 15, 2022
@jrmhaig can you please resolve conflicts? We really need to switch to GH Actions. |
jrmhaig
commented
Aug 17, 2022
Sorry, I pressed the wrong button and marked this as ready for review. Conflicts are not yet resolved. |
justin808
commented
Aug 17, 2022
justin808
commented
Oct 19, 2022
@ahangarha Please take this over and make a new PR. I'll close this issue when your PR is up. |
ahangarha
commented
Nov 14, 2022
May I know the objective of this PR? We already have migrated from travis to GitHub actions (#1198) and as far as I see, all tests pass. What issue is being addressed here? Are we still trying to use travis? |
jrmhaig
commented
Nov 14, 2022
I opened this ticket over a year ago, before you migrated to Github actions. I cannot remember exactly what I was doing but I may have been trying to update it for a newer version of Rails but got stopped because I couldn't get the tests to run. I think it was somehow tied up with the If the tests have moved to Github actions and are now working then obviously this can be closed. |
@justin808 May you share your thoughts? |
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs/react-rails#1114.
Summary
WIP
Updating to get the tests working and updated for new versions of Ruby and Rails.
Other Information
mimemagicinGemfile.lock. The currently linked version was yanked.To do (help needed)
The tests are failing with the
rails_5.2_no_sprockets_webpacker_*gemfiles:It look as though the way to start webpack has changed from
webpack-dev-servertowebpack serverbut I don't understand the codebase enough to know what needs updating for this.For reference: webpack/webpack-dev-server#2759