Switch to GitHub Actions for testing by hibachrach · Pull Request #1198 · reactjs/react-rails

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach · 2022-08-26T05:06:29Z

Converts from Travis to GH actions. Fixes#1193

hibachrach · 2022-08-27T04:57:30Z

Ah I think #1150 broke some of the tests a bit more. The new version of webpack-dev-server has a bug because of an undeclared dependency (webpack/webpack-dev-server#2396) and changed the peer dependency support to be webpack@^4.0.0. Not sure how to proceed

hibachrach · 2022-08-27T04:59:26Z

I do think we ought to revisit the supported versions of Webpacker with this gem. I'm generally new to this sort of thing so unsure of where to cut things off (especially considering non-Shakapacker Webpacker is already retired).

justin808 · 2022-08-30T05:50:25Z

@HarrisonB I agree with you. I opened an issue for this: #1199.

justin808 · 2022-09-09T09:35:46Z

@HarrisonB any update? I mentioned that we can revert the new webpack-dev-server until we get CI running.

See here for an argument as to why to do so

See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Issue was introduced in minitest/minitest@6fecff9 and hack workaround was introduced in minitest/minitest@b8ddc4f I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later.

This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: ruby/setup-ruby#108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow.

justin808 · 2022-09-14T01:20:09Z

@HarrisonB let me know when to review.

This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach · 2022-09-14T20:52:02Z

@justin808 It's now ready for review

justin808

LGTM

justin808 · 2022-09-16T08:59:38Z

Thanks, @hibachrach. Let's see if this runs! We might need some followups.

justin808 · 2022-09-16T09:00:03Z

Looks like it's running: https://github.com/reactjs/react-rails/actions

See reactjs#1198

hibachrach force-pushed the switch-to-github-actions branch 3 times, most recently from c9c7d20 to efbf304Compare August 26, 2022 05:30

hibachrach changed the title ~~TEMP Switch to GitHub Actions for testing~~Switch to GitHub Actions for testingAug 26, 2022

hibachrach mentioned this pull request Aug 30, 2022
Expose all built-in options for getConstructor#1050
Merged

justin808 mentioned this pull request Aug 30, 2022
What versions of Webpacker/Shakapacker to support going forward? #1199
Closed

hibachrach mentioned this pull request Sep 10, 2022
Revert "Bump webpack-dev-server from 2.11.5 to 3.1.11 in /test/dummy_webpacker3" #1202
Merged

hibachrach force-pushed the switch-to-github-actions branch 2 times, most recently from ee464a1 to 3f0f44aCompare September 12, 2022 01:32

hibachrach added 4 commits September 11, 2022 18:33

Switch to GitHub Actions for testing
eca3e8d
See here for an argument as to why to do so

Update rails past 5.2.5 to work around yanked mimemagic
255f82f
See these links for context: * rails/rails#41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases

Drop end-of-life Ruby 2.5 from testing matrix
dd2e249
This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version

hibachrach force-pushed the switch-to-github-actions branch from 3f0f44a to dd2e249Compare September 12, 2022 01:34

hibachrach force-pushed the switch-to-github-actions branch from c48ffa6 to 5f6062dCompare September 12, 2022 04:57

Temporarily drop testing against JRuby
1c282a6
This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309)

hibachrach force-pushed the switch-to-github-actions branch from c44ad6a to 1c282a6Compare September 14, 2022 20:50

hibachrach marked this pull request as ready for review September 14, 2022 20:51

justin808 approved these changes Sep 16, 2022
View reviewed changes

justin808 merged commit f873861 into reactjs:masterSep 16, 2022

hibachrach deleted the switch-to-github-actions branch September 17, 2022 00:23

hibachrach added a commit to hibachrach/react-rails that referenced this pull request Sep 17, 2022
Update status bage to point to GitHub Actions
e3c13cf
See reactjs#1198

hibachrach mentioned this pull request Sep 17, 2022
Update status bage to point to GitHub Actions #1205
Merged

ahangarha mentioned this pull request Nov 14, 2022
Get tests passing #1114
Closed