Skip to content

Translation FAQ: Passing Functions to Components - #108

Merged
another-guy merged 7 commits into
reactjs:masterfrom
marichka-offen:translation-faq-functions
Feb 22, 2019
Merged

Translation FAQ: Passing Functions to Components#108
another-guy merged 7 commits into
reactjs:masterfrom
marichka-offen:translation-faq-functions

Conversation

@marichka-offen

@marichka-offenmarichka-offen commented Feb 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Перезалито с PR #95

@marichka-offenmarichka-offen changed the title Translation FAQ functions componentsTranslation FAQ: Passing Functions to ComponentsFeb 12, 2019
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/faq-functions.md
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
marichka-offenand others added 2 commits February 12, 2019 17:53
@marichka-offen
Fix ё
d99dd63
@lex111@marichka-offen
Apply suggestions from code review
c36d09f
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил ещё предложения, можете прямо из гитхаба их прнять, никогда так не делал, но должно работать.

Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
@lex111@marichka-offen
Apply suggestions from code review
f8771e1
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
another-guy
another-guy reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/faq-functions.md Outdated
another-guy
another-guy reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/faq-functions.md Outdated
another-guy
another-guy reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/faq-functions.md Outdated
@tesseralistesseralis mentioned this pull request Feb 12, 2019
Closed
88 tasks
another-guy
another-guy reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/faq-functions.md Outdated
@lex111

lex111 commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Ещё заметил, что не везде используется буква "ё", можно воспользоваться пакетом, который автоматически проставит её (второй пункт)

@another-guyanother-guy added the work in progress Author opened the pull-request but it's still being worked on label Feb 12, 2019
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/faq-functions.md Outdated
@lex111lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 14, 2019
lex111
lex111 approved these changes Feb 14, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне всё нравится 👍

@gcor

gcor commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

Отрисовка → рендер

another-guy
another-guy approved these changes Feb 20, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пожалуйста, исправьте несколько помарок. ✏️

Спасибо огромное за работу над переводом! 🎉

Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
@another-guyanother-guy removed their assignment Feb 20, 2019
@lex111

lex111 commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

@marichka-offen можете, пожалуйста, рассмотреть предложенные правки и принять их? Если по каким-либо причинам не можете, то это сделаем мы.

@another-guyanother-guy self-assigned this Feb 21, 2019
@another-guy@marichka-offen
Apply suggestions from code review
bf36c02
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
@netlify

netlifyBot commented Feb 22, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit bf36c02

https://deploy-preview-108--ru-reactjs.netlify.com

1 similar comment
@netlify

netlifyBot commented Feb 22, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit bf36c02

https://deploy-preview-108--ru-reactjs.netlify.com

@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 22, 2019
@another-guy

another-guy commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

@marichka-offen 💯 ! 🥇

@another-guy
another-guy merged commit 54ea4e6 into reactjs:masterFeb 22, 2019
@another-guyanother-guy removed their assignment Mar 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@another-guyanother-guyanother-guy approved these changes
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marichka-offen@lex111@gcor@another-guy