Skip to content

Translation FAQ passing functions to components - #95

Closed
marichka-offen wants to merge 3 commits into
reactjs:masterfrom
marichka-offen:translation-faq-passing-functions-to-components
Closed

Translation FAQ passing functions to components#95
marichka-offen wants to merge 3 commits into
reactjs:masterfrom
marichka-offen:translation-faq-passing-functions-to-components

Conversation

@marichka-offen

@marichka-offenmarichka-offen commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@marichka-offenmarichka-offen mentioned this pull request Feb 12, 2019
Closed
88 tasks
@another-guy

another-guy commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Один из самых качественных переводов, что я ревьюил!

Мне кажется, правда, Thinking in React просочился откуда-то...

another-guy
another-guy suggested changes Feb 12, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо что-то решить с Thinking in React...

Comment threadcontent/docs/faq-functions.md
```

#### Class Properties (Stage 3 Proposal) {#class-properties-stage-3-proposal}
#### Привязка в свойствах класса (Stage 3 Proposal) {#class-properties-stage-3-proposal}

@another-guyanother-guyFeb 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стоит ли переводить "Stage 3 Proposal". 🤔

@marichka-offenmarichka-offenFeb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно. Есть идеи как лучше это сделать?

@another-guyanother-guyFeb 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

"предложение на стадии Кандидата" звучит кривовато :(

@marichka-offenmarichka-offenFeb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот я тоже так подумала когда гуглила варианты. Может его вообще убрать?

@lex111lex111Feb 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

предложение-кандидат можно (https://medium.com/web-standards/es2019-417d8b406346)

Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/faq-functions.md Outdated
Comment threadcontent/docs/thinking-in-react.md
@marichka-offenmarichka-offen mentioned this pull request Feb 12, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lex111lex111lex111 left review comments
@another-guyanother-guyanother-guy requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marichka-offen@another-guy@lex111