Skip to content

Translate "Getting Started" (getting-started.md) - #39

Merged
lex111 merged 11 commits into
reactjs:masterfrom
AlLevykin:getting-started-translate
Feb 11, 2019
Merged

Translate "Getting Started" (getting-started.md)#39
lex111 merged 11 commits into
reactjs:masterfrom
AlLevykin:getting-started-translate

Conversation

@AlLevykin

@AlLevykinAlLevykin commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

avevlad
avevlad reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
@avevladavevlad mentioned this pull request Feb 9, 2019
Closed
avevlad
avevlad reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 suggested changes Feb 9, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, коммментарии очень беглого обзора, пока рекомендуем прочитать руководство.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@lex111
lex111 requested a review from gaearonFebruary 9, 2019 23:20
gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я оставил первые несколько комментариев — проблемные места похожи, так что я предлагаю их поправить и пройтись по всему тексту в поисках похожих проблем. Потом посмотрю еще )

Спасибо.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
88 tasks
gaearon
gaearon reviewed Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уже лучше! Несколько замечаний.

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
@gaearongaearon added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще один раунд, мы близко

Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
gaearon
gaearon reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/getting-started.md Outdated
gaearon
gaearon approved these changes Feb 11, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С моей стороны всё ок, оставляю @lex111 на мёрж

@lex111
lex111 merged commit 0672717 into reactjs:masterFeb 11, 2019
@lex111

lex111 commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

@AlLevykin спасибо!

@lex111lex111 mentioned this pull request Feb 11, 2019
Merged
@gaearongaearon mentioned this pull request Feb 12, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon approved these changes
+2 more reviewers
@avevladavevladavevlad left review comments
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

work in progressAuthor opened the pull-request but it's still being worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlLevykin@lex111@gaearon@avevlad