Skip to content

translate Thinking in React - #90

Merged
gaearon merged 13 commits into
reactjs:masterfrom
marichka-offen:translation-basics-thinking-in-react
Feb 13, 2019
Merged

translate Thinking in React#90
gaearon merged 13 commits into
reactjs:masterfrom
marichka-offen:translation-basics-thinking-in-react

Conversation

@marichka-offen

@marichka-offenmarichka-offen commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@marichka-offenmarichka-offen mentioned this pull request Feb 11, 2019
Closed
88 tasks
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/thinking-in-react.md Outdated
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 11, 2019
angryermine
angryermine reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
spokvulcan
spokvulcan reviewed Feb 12, 2019
View reviewed changes

@spokvulcanspokvulcan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мои небольшие предложения

Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
spokvulcan
spokvulcan reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/thinking-in-react.md Outdated
angryermine
angryermine reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/thinking-in-react.md Outdated
gaearon
gaearon requested changes Feb 12, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, надо поправить пару вещей

Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
gaearon
gaearon requested changes Feb 12, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо! Есть одна претензия, которая по всему тексту — надо упростить сложные предложения

Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md

But how do you know what should be its own component? Just use the same techniques for deciding if you should create a new function or object. One such technique is the [single responsibility principle](https://en.wikipedia.org/wiki/Single_responsibility_principle), that is, a component should ideally only do one thing. If it ends up growing, it should be decomposed into smaller subcomponents.
Но как узнать, что является компонентом, а что нет? Всё очень просто: это похоже на то, как вы решаете, надо ли объявить функцию или объект. Один из таких методов — [принцип единственной ответственности](https://ru.wikipedia.org/wiki/Принцип_единственной_ответственности), суть которого состоит в том, что в идеале компонент должен выполнять только одну поставленную задачу. Если в конечном итоге функционал компонента увеличивается, его следует разбить на более мелкие подкомпоненты.

@gaearongaearonFeb 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

То же самое — упрощайте и разбивайте длинные предложения

@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
@marichka-offenmarichka-offen mentioned this pull request Feb 12, 2019
Merged
lex111
lex111 reviewed Feb 13, 2019
View reviewed changes
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
Comment threadcontent/docs/thinking-in-react.md Outdated
lex111and others added 4 commits February 12, 2019 22:27
@lex111@marichka-offen
Apply suggestions from code review
5122d3b
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
@marichka-offen
Apply suggestions from code review
6c846bc
@gaearon
Update thinking-in-react.md
1b623b3
@gaearon
nits
a79465e
gaearon
gaearon approved these changes Feb 13, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень хорошо. Поправил мелочи. Спасибо.

@gaearon
gaearon merged commit aaf64e5 into reactjs:masterFeb 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon approved these changes
+3 more reviewers
@angryermineangryermineangryermine left review comments
@lex111lex111lex111 left review comments
@spokvulcanspokvulcanspokvulcan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

work in progressAuthor opened the pull-request but it's still being worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marichka-offen@gaearon@angryermine@lex111@spokvulcan@another-guy