Skip to content

Replace SecureStream with unlimited read buffer from react/stream v0.4.5 - #72

Merged
clue merged 2 commits into
reactphp-legacy:masterfrom
clue-labs:wrap
Dec 19, 2016
Merged

Replace SecureStream with unlimited read buffer from react/stream v0.4.5#72
clue merged 2 commits into
reactphp-legacy:masterfrom
clue-labs:wrap

Conversation

@clue

@clueclue commented Nov 15, 2016

Copy link
Copy Markdown
Contributor

This is not a BC break because the undocumented(!) SecureStream extends the Stream class.

@clueclue added this to the v0.5.2 milestone Nov 16, 2016
@clueclue changed the title [WIP] Replace SecureStream with unlimited read buffer from react/stream v0.4.5Replace SecureStream with unlimited read buffer from react/stream v0.4.5Dec 5, 2016
@clue

clue commented Dec 5, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased now that #51 is in and removed the WIP marker because this is now ready for merge IMO :shipit:

@WyriHaximusWyriHaximus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@clue
clue merged commit 223e0a3 into reactphp-legacy:masterDec 19, 2016
@clue
clue deleted the wrap branch December 19, 2016 23:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus