Skip to content

Use connect($uri) instead of create($host, $port) - #74

Merged
clue merged 4 commits into
reactphp-legacy:masterfrom
clue-labs:uri
Jan 9, 2017
Merged

Use connect($uri) instead of create($host, $port)#74
clue merged 4 commits into
reactphp-legacy:masterfrom
clue-labs:uri

Conversation

@clue

@clueclue commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

This PR combines dedicated $host and $uri parameters into a single $uri. This is obviously a BC break, so let's rename the method to a more meaningful name while we're at it.

There are plenty of reasons, let me try to list a few here:

See also the individual commits if you want to review the changes.

@clue

clue commented Dec 19, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased now that #72 is in :shipit:

@jsorjsor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus