Uh oh!
There was an error while loading. Please reload this page.
Forward compatibility with react/promise 3 - #33
Merged
Conversation
clue
commented
Sep 9, 2022
Member
@WyriHaximus Good initiative and would love to see this getting some traction again! What are your plans for this PR? It looks like all outstanding PRs have been merged in the meantime? (reactphp/dns#153, reactphp/promise-timer#55, reactphp/promise-timer#54, reactphp/promise-timer#37) |
WyriHaximusforce-pushed
the
promise-3
branch
2 times, most recently
from
September 9, 2022 18:09
d45b662 to
98ab0fdCompareWyriHaximus
commented
Sep 9, 2022
MemberAuthor
@cluehttps://github.com/reactphp/datagram/actions/runs/3024442084 shows it passing with promise v3 (@dev) working for supported PHP versions. |
WyriHaximusforce-pushed
the
promise-3
branch
2 times, most recently
from
September 9, 2022 18:12
ba04c8c to
1635cc1Compareclue
reviewed
Sep 10, 2022
Uh oh!
There was an error while loading. Please reload this page.
clue
approved these changes
Sep 11, 2022
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.