Uh oh!
There was an error while loading. Please reload this page.
Forward compatibility with react/promise 3 - #153
Merged
Conversation
WyriHaximusforce-pushed
the
promise-3
branch
2 times, most recently
from
April 26, 2020 17:09
5d6aee7 to
190500fCompareclue
reviewed
Apr 26, 2020
| { | ||
| $deferred = new Deferred(function () use (&$promise) { | ||
| if ($promise instanceof CancellablePromiseInterface) { | ||
| if ($promise instanceof CancellablePromiseInterface || (method_exists($promise, 'cancel') && $promise instanceof PromiseInterface)) { |
Member
There was a problem hiding this comment.
Might as well get rid of the
instanceofor use the more explicit$promise instanceof CancellablePromiseInterface || (!interface_exists('React\Promise\CancellablePromiseInterface') && \method_exists($promise, 'cancel'). What do you think about this? (see also below) – via https://github.com/reactphp/promise-timer/pull/37/files#r415381931
clue
approved these changes
Apr 27, 2020
jsor
approved these changes
Apr 28, 2020
This was referenced Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.