Skip to content

[RFC] Improve compatibility with legacy versions - #101

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:compat
Feb 9, 2017
Merged

[RFC] Improve compatibility with legacy versions#101
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:compat

Conversation

@clue

@clueclue commented Feb 9, 2017

Copy link
Copy Markdown
Member

Because why not… :-)

Now more seriously: This project is a low level lib that is used as a building block for quite a few higher level abstractions on top of it. As such, compatibility (even with significantly outdated versions) is a major concern to me.

Note that I'm not suggesting putting significant amount of work into this. The patch is already here and, personally, I see little harm in supporting this.

Also note that I'm not suggesting we need to keep support indefinitely. Should this ever turn out to be a burden in the future, e.g. because we actually require any new language features or some external lib, then I'm all for dropping support again.

@clueclue added this to the v0.4.3 milestone Feb 9, 2017
@kelunik

Copy link
Copy Markdown

Note that it installs react/promise@v1.2.1, as the current version requires php>=5.4. Also, will requiring PHP 5.4 then be considered as a BC break and require a new major version?

@WyriHaximus
WyriHaximus requested a review from jsorFebruary 9, 2017 17:38
@WyriHaximus

Copy link
Copy Markdown
Member

@clue While the changes are small I do like to move forward somewhere this year, preferable to PHP 7+.

jsor
jsor approved these changes Feb 9, 2017
@WyriHaximus

Copy link
Copy Markdown
Member

@clue could you merge in master and resolve the merge conflicts?

@clue

clue commented Feb 9, 2017

Copy link
Copy Markdown
MemberAuthor

Rebased now that #100 is in :shipit:

@kelunik Yes, raising the minimum required version would technically be a BC break again. But as @WyriHaximus has pointed out, we will likely bump to PHP 7/7.1 at some (future) point anyway 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@clue@kelunik@WyriHaximus@jsor