Uh oh!
There was an error while loading. Please reload this page.
Remove unneeded stubs from tests - #100
Merged
Merged
Conversation
clue
requested changes
Feb 9, 2017
| ->withConsecutive( | ||
| array($this->equalTo("HTTP/1.1 200 OK\r\nX-Powered-By: React/alpha\r\nTransfer-Encoding: chunked\r\n\r\n")), | ||
| array($this->equalTo("0\r\n\r\n")) | ||
| ); |
Member
There was a problem hiding this comment.
LGTM, but doesn't match with the test title anymore?
| public function testRequestEventIsEmitted() | ||
| { | ||
| $io = new ServerStub(); | ||
| $socket = new Socket($this->loop); |
Member
There was a problem hiding this comment.
How about using a mock here? (refs #93)
See also below.
ContributorAuthor
Updated. Checkout the newest commits. |
jsor
approved these changes
Feb 9, 2017
jsor
left a comment
Member
There was a problem hiding this comment.
Pesonally, I'd have preferred factory methods for creating the mocks, but i'm good with either.
WyriHaximus
approved these changes
Feb 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stubs aren't needed in the tests and can be replaced by a simple Connection mock.
This will make it easier to create tests for an upcoming PSR-7 PR.