Skip to content

Run tests on PHPUnit 9 and clean up test suite - #364

Merged
jsor merged 2 commits into
reactphp:masterfrom
SimonFrings:tests
Jul 3, 2020
Merged

Run tests on PHPUnit 9 and clean up test suite#364
jsor merged 2 commits into
reactphp:masterfrom
SimonFrings:tests

Conversation

@SimonFrings

Copy link
Copy Markdown
Member

No description provided.

@SimonFrings
SimonFringsforce-pushed the tests branch 4 times, most recently from 4ebced4 to 1917779CompareJune 30, 2020 11:56

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clueclue added this to the v0.8.7 milestone Jun 30, 2020
@clue
clue requested review from WyriHaximus and jsorJune 30, 2020 12:07
Comment threadtests/TestCase.php Outdated
clue
clue approved these changes Jul 2, 2020

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update! :shipit:

jsor
jsor approved these changes Jul 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SimonFrings@jsor@WyriHaximus@clue