Uh oh!
There was an error while loading. Please reload this page.
Update PHPUnit configuration schema for PHPUnit 9.3 and replace deprecated at() Mocks - #393
Merged
Conversation
SimonFringsforce-pushed
the
tests
branch
3 times, most recently
from
September 3, 2020 12:32
7b460dd to
04c8024Compareclue
approved these changes
Sep 3, 2020
clue
left a comment
Member
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
WyriHaximus
approved these changes
Sep 3, 2020
jsor
approved these changes
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 9.3 released a new schema for the
phpunit.xmlconfiguration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use thephpunit.xml.legacyconfiguration file, because the new format is unknown for them.I also had to update some tests, because the
at()matcher deprecated in PHPUnit 9.3 and will be removed in PHPUnit 10.Together with the changes from #391 by @clue it's possible to run this code with PHP 8 without any warnings in your output 🎉
$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0.0beta2-cli php vendor/bin/phpunit PHPUnit 9.3.8 by Sebastian Bergmann and contributors. ............................................................... 63 / 673 ( 9%) ............................................................... 126 / 673 ( 18%) ............................................................... 189 / 673 ( 28%) ............................................................... 252 / 673 ( 37%) ............................................................... 315 / 673 ( 46%) ............................................................... 378 / 673 ( 56%) ............................................................... 441 / 673 ( 65%) ............................................................... 504 / 673 ( 74%) ............................................................... 567 / 673 ( 84%) ............................................................... 630 / 673 ( 93%) ........................................... 673 / 673 (100%) Time: 00:16.651, Memory: 20.00 MB OK (673 tests, 1604 assertions)For further details concerning this pull request look into graphp/graphviz#46.
This pull request builds on top of reactphp/http#364.