Uh oh!
There was an error while loading. Please reload this page.
File object - #62
Conversation
clue
commented
Aug 30, 2016
I guess it makes sense to adopt PSR-7's naming convention? http://www.php-fig.org/psr/psr-7/#3-6-psr-http-message-uploadedfileinterface |
WyriHaximus
commented
Aug 30, 2016
That makes sense, including method names? But I think actually implementing PSR-7 should be done in a/the next BC release |
WyriHaximus
commented
Aug 30, 2016
@clue updated PR to make them resemble PSR-7 UploadedFIle |
WyriHaximus
commented
Sep 13, 2016
Ping @clue |
| use React\Stream\ReadableStreamInterface; | ||
| class UploadedFile implements UploadedFileInterface |
clue
commented
Sep 13, 2016
This code looks good to me – except that it doesn't have any use case right now :-) IMO it makes sense to also introduce the use case in the same PR as this one would be rather pointless otherwise. |
WyriHaximus
commented
Sep 13, 2016
Yes it is rather pointless with out a use case. But to avoid creating an enormous PR again I'm going to have a set of PR's depending on each. Those PR's contain small logical components. |
jsor
commented
Oct 24, 2016
👍 LGTM |
clue
commented
Feb 16, 2017
Didn't mean to close this one, only cleaned up a (seemingly unrelated) feature branch. @WyriHaximus does it make sense to file this again or do you want until the milestone is ready? 👍 |
WyriHaximus
commented
Jun 20, 2017
Superseded by #199 |
This is the first PR extracted from #41 and is solely for the
Fileobject used in the streaming body parser's. (See #41 (comment) for reference.)