[WIP] Streaming parser bufferedsink

[WyriHaximus]

Just like the bufferedsink from stream and #70 but this sink takes a streaming body parser and buffers any post field, body data, or uploaded file. Once the full request it in the promise will resolve.

Depends on #69 and #62

• BufferedSink for streaming parsers
• Class/Method Documentation
• Readme Documentation
• Split up sink in a file, post, and body sink
• Merge master in when Streaming body parsers foundation #69 and File object #62 are in
• Ensure tests are up to date and passing
• Squash on merge

[jsor]

This should be done instead of then.

[jsor]

What about splitting this into 3 distinct sinks: a body, post and files sink. The sinks could be composed with parts you need. The resolution array from the current implementation could be achieved with

$promises = [
'body' => BodyBufferedSink::createPromise($parser),
'post' => PostBufferedSink::createPromise($parser),
'files' => FilesBufferedSink::createPromise($parser),
];
React\Promise\all($promises)->done($result) {
// $result contains 'body', 'post' and 'files `entries
});

[WyriHaximus]

That is actually a great idea 👍 !

[WyriHaximus]

@jsor updated the PR with the split up BufferedSink, left the BufferedSink in for reference for now.

[jsor]

s/PostPost/Post

[jsor]

Maybe the BufferedSink can stay as

class BufferedSink
{
/** * @param ParserInterface $parser * @return PromiseInterface */publicstaticfunctioncreatePromise(ParserInterface$parser)
{
$promises = [
'body' => BodyBufferedSink::createPromise($parser),
'post' => PostBufferedSink::createPromise($parser),
'files' => FilesBufferedSink::createPromise($parser),
];
returnPromise\all($promises);
}
}