Skip to content

Replace PHPUnit's getMock() for forward compatibility - #93

Merged
clue merged 1 commit into
reactphp:masterfrom
nopolabs:fix/avoid-getMock-deprecsation-warnings
Feb 6, 2017
Merged

Replace PHPUnit's getMock() for forward compatibility#93
clue merged 1 commit into
reactphp:masterfrom
nopolabs:fix/avoid-getMock-deprecsation-warnings

Conversation

@nopolabs

Copy link
Copy Markdown
Contributor

per comment in reactphp/event-loop#68 (comment)
with respect of replacing usage of getMock to avoid deprecation warnings with newer versions
of phpunit

jsor
jsor approved these changes Feb 6, 2017
clue
clue approved these changes Feb 6, 2017

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaict this isn't really needed now that #92 is in, but it doesn't do any harm and I guess this makes sense for forward compatibility anyway 👍

@clueclue changed the title replace getMock for forward compatibilityReplace PHPUnit's getMock() for forward compatibilityFeb 6, 2017
@clue
clue merged commit 38cc193 into reactphp:masterFeb 6, 2017
@WyriHaximusWyriHaximus added this to the v0.4.3 milestone Feb 6, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nopolabs@jsor@clue@WyriHaximus