Enforce Throwable rejection reason and require PHP 7+ as a consequence by WyriHaximus · Pull Request #138 · reactphp/promise

WyriHaximus · 2019-04-19T15:49:27Z

By enforcing Throwable as a rejection reason:

Get rid of all the double checks for Throwable and Exception
Can use typehints for it since we dropped direct Exception support (still supported through Throwable)
Bump to PHP 7.x+
Add note about support for older versions

clue

Changes LGTM 👍 I'll await @jsor's review first, but I don't see any major blockers.

I wonder if it makes sense to add test cases for incorrect usage, i.e. how an automatic TypeError for invalid arguments will bubble through common promise handlers etc.?

WyriHaximus · 2019-04-22T20:03:50Z

I wonder if it makes sense to add test cases for incorrect usage, i.e. how an automatic TypeError for invalid arguments will bubble through common promise handlers etc.?

Makes sense, I'll add those 👍

WyriHaximus · 2019-04-22T20:27:31Z

@jsor now that everything must be a Throwable does the fatalError function still make sense?

jsor · 2019-04-23T08:47:34Z

now that everything must be a Throwable does the fatalError function still make sense?

Not sure what you mean?

WyriHaximus · 2019-04-23T09:25:36Z

now that everything must be a Throwable does the fatalError function still make sense?
Not sure what you mean?

If you look at this failed test cause for example, this exception shouldn't have been thrown not triggered as an error: https://travis-ci.org/reactphp/promise/jobs/523187495#L499

jsor · 2019-04-23T09:32:24Z

@WyriHaximus In #97, we intentionally switched from throwing exceptions to aborting with a fatal error. Exceptions should (and after that patch actually do) never bubble out of the promise chain. You need to use the ErrorCollector in the tests, see eg. https://github.com/reactphp/promise/blob/master/tests/PromiseTest/PromiseFulfilledTestTrait.php#L219-L236

WyriHaximus · 2019-04-23T09:40:38Z

@jsor ah awesome thanks 👍

WyriHaximus · 2019-04-23T15:20:43Z

@jsor / @clue Ok added those tests.

WyriHaximus · 2019-04-26T06:07:36Z

@clue / @jsor Added the note about supporting 2.0 and 1.0

Bump minimum required and tested PHP version to 7.0 as a result of requiring Throwables. Renamed the nesecary exceptions, methods and properties to match the new Throwable naming.

WyriHaximus · 2019-05-09T06:00:49Z

@jsor @clue Processed the last comments and discussions. Also squashed everything into one commit.

WyriHaximus · 2019-05-09T06:10:42Z

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

…consequence With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type hints to all our public and private functions. To give all functions return type hints we need the `void` return type, which isn't available until PHP 7.1. So in order use that we also have to bump the the minimum required PHP version for this package to PHP 7.1.

…consequence With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type hints to all our public and private functions. To give all functions return type hints we need the `void` return type, which isn't available until PHP 7.1. So in order use that we also have to bump the the minimum required PHP version for this package to PHP 7.1. The benefit of return type hints is the ensurance at language level of our return values. For ourselfs and our consumers.

…consequence With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type hints to all our public and private functions. To give all functions return type hints we need the `void` return type, which isn't available until PHP 7.1. So in order use that we also have to bump the the minimum required PHP version for this package to PHP 7.1. The benefit of return type hints is the assurance at language level of our return values. For ourself and our consumers.

WyriHaximus added help wanted maintenance easy pick labels Apr 19, 2019

WyriHaximus added this to the v3.0.0 milestone Apr 19, 2019

WyriHaximus requested review from clue and jsor April 19, 2019 15:49

clue added the BC break label Apr 19, 2019

clue reviewed Apr 19, 2019
View reviewed changes

Comment threadsrc/RejectedPromise.php Outdated
Comment threadsrc/Exception/CompositeException.php

WyriHaximus changed the title ~~[WIP] Raise minimum PHP version to 7.0~~[WIP] Enforce Throwable rejection reason and require PHP 7+ as a consequenceApr 20, 2019

clue reviewed Apr 20, 2019
View reviewed changes

WyriHaximus force-pushed the php-7.x branch from 89fdfb3 to 78daa3fCompare April 23, 2019 15:19

WyriHaximus requested a review from clue April 23, 2019 15:20

WyriHaximus force-pushed the php-7.x branch from 78daa3f to 3532885Compare April 23, 2019 20:33

WyriHaximus changed the title ~~[WIP] Enforce Throwable rejection reason and require PHP 7+ as a consequence~~Enforce Throwable rejection reason and require PHP 7+ as a consequenceApr 26, 2019

jsor reviewed May 1, 2019
View reviewed changes

Comment threadREADME.md Outdated
Comment threadsrc/Exception/CompositeException.php
Comment threadtests/FunctionRejectTest.php Outdated

WyriHaximus force-pushed the php-7.x branch from 92b156e to 541aee5Compare May 1, 2019 15:26

clue approved these changes May 8, 2019
View reviewed changes

Comment threadtests/FunctionRejectTest.php Outdated

Require Throwable as rejection reason
505cf5e
Bump minimum required and tested PHP version to 7.0 as a result of requiring Throwables. Renamed the nesecary exceptions, methods and properties to match the new Throwable naming.

WyriHaximus force-pushed the php-7.x branch from 541aee5 to 505cf5eCompare May 9, 2019 05:59

jsor approved these changes May 9, 2019
View reviewed changes

jsor merged commit edd18a6 into reactphp:masterMay 9, 2019

This was referenced May 9, 2019
Throwable type improvements #141
Merged
Use \Throwable exclusively in rejection function docs #142
Merged

WyriHaximus mentioned this pull request Oct 7, 2019
Enforce return type hints on all functions and require PHP 7.1+ as a consequence #149
Merged

clue mentioned this pull request Jan 23, 2022
Add catch() and finally(), deprecate otherwise() and always()#208
Merged

This was referenced Feb 24, 2022
Require argument for resolve() function #213
Merged
Improve forward compatibility with upcoming Promise v3 API reactphp/promise-timer#54
Merged

This was referenced Jun 22, 2022
Forward compatibility with upcoming Promise v3 reactphp/http#460
Merged
Forward compatibility with upcoming Promise v3 friends-of-reactphp/mysql#157
Merged

clue mentioned this pull request Aug 25, 2022
Forward compatibility with react/promise 3 reactphp/socket#214
Merged

This was referenced Sep 3, 2022
Forward compatibility with upcoming Promise v3 clue/reactphp-sqlite#63
Merged
Forward compatibility with upcoming Promise v3 clue/framework-x#188
Merged

clue mentioned this pull request Sep 9, 2023
Describe all callable arguments with types for Promise and Deferred#253
Merged

Uh oh!

Uh oh!

Conversation

WyriHaximus commented Apr 19, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clue left a comment

Choose a reason for hiding this comment

Uh oh!

WyriHaximus commented Apr 22, 2019

Uh oh!

WyriHaximus commented Apr 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsor commented Apr 23, 2019

Uh oh!

WyriHaximus commented Apr 23, 2019

Uh oh!

jsor commented Apr 23, 2019

Uh oh!

WyriHaximus commented Apr 23, 2019

Uh oh!

WyriHaximus commented Apr 23, 2019

Uh oh!

WyriHaximus commented Apr 26, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WyriHaximus commented May 9, 2019

Uh oh!

WyriHaximus commented May 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WyriHaximus commented Apr 19, 2019•
edited
Loading

WyriHaximus commented Apr 22, 2019•
edited
Loading