Skip to content

Forward compatibility with react/promise 3 - #214

Merged
WyriHaximus merged 1 commit into
reactphp:1.xfrom
WyriHaximus-labs:promise-3
Aug 25, 2022
Merged

Forward compatibility with react/promise 3#214
WyriHaximus merged 1 commit into
reactphp:1.xfrom
WyriHaximus-labs:promise-3

Conversation

@WyriHaximus

@WyriHaximusWyriHaximus commented Oct 10, 2019•
edited by clue
Loading

Copy link
Copy Markdown
Member

@WyriHaximus
WyriHaximusforce-pushed the promise-3 branch 2 times, most recently from ffd7b3c to aa427cfCompareOctober 30, 2019 07:20
@WyriHaximus
WyriHaximusforce-pushed the promise-3 branch 2 times, most recently from a274edb to c3b237cCompareSeptember 23, 2020 19:31
@WyriHaximusWyriHaximus mentioned this pull request Sep 23, 2020
Closed
@WyriHaximus
WyriHaximusforce-pushed the promise-3 branch 9 times, most recently from 5c580d3 to e003928CompareSeptember 30, 2020 17:55
@clueclue mentioned this pull request Jun 25, 2021
Merged
@clueclue mentioned this pull request Mar 3, 2022
Merged
@clue

clue commented Jun 12, 2022

Copy link
Copy Markdown
Member

@WyriHaximus Good initiative and would love to see this getting some traction again! What are your plans for this PR? It looks like this is currently the only outstanding PR for ReactPHP to support Promise v3.

@WyriHaximus

WyriHaximus commented Jun 12, 2022

Copy link
Copy Markdown
MemberAuthor

@clue Well lets make this PR get traction again then! Will rebase and get it back into passing shape in the coming few days.

@clue

clue commented Jun 12, 2022

Copy link
Copy Markdown
Member

@WyriHaximus Perfect! It looks like this might be blocked by reactphp/promise-timer#54 at the moment, so I'll look into releasing the outstanding PromiseTimer version the next couple of days 👍

@WyriHaximus

WyriHaximus commented Jun 12, 2022

Copy link
Copy Markdown
MemberAuthor

@clue Cheers, still need to deal with nearly 100+ errors/failures at my local current rebase. Will push it when the tests don't get stuck anymore. (They just run for a long time at the moment.)

@WyriHaximus

WyriHaximus commented Jun 12, 2022

Copy link
Copy Markdown
MemberAuthor

Took about 3 minutes to run locally, will have a look at fixing errors tomorrow

@WyriHaximus
WyriHaximusforce-pushed the promise-3 branch 2 times, most recently from 19f23f5 to 11b168eCompareJune 13, 2022 20:48
@clueclue added this to the v1.12.0 milestone Jun 21, 2022
This was referenced Jun 22, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@WyriHaximus
WyriHaximusforce-pushed the promise-3 branch 5 times, most recently from bd77fc4 to dc9b9c6CompareJuly 14, 2022 18:00
WyriHaximus
WyriHaximus commented Jul 15, 2022
View reviewed changes
Comment threadtests/HappyEyeBallsConnectionBuilderTest.php Outdated
@WyriHaximus
WyriHaximusforce-pushed the promise-3 branch 2 times, most recently from b93de58 to 4d073c0CompareJuly 15, 2022 06:44
@WyriHaximusWyriHaximus changed the title [WIP] Forward compatibility with react/promise 3Forward compatibility with react/promise 3Aug 25, 2022
@WyriHaximus
WyriHaximus requested a review from clueAugust 25, 2022 09:26
@clue

clue commented Aug 25, 2022

Copy link
Copy Markdown
Member

I've rebased this on the current 1.x branch now that #296 is in. Since reactphp/promise#229 has been merged in the meantime, I've been able to remove most of the work-arounds in this PR and could simplify this quite a bit. In essence, this is still @WyriHaximus's original changes with all changes reverted that are no longer necessary. Let's get this shipped! :shipit:

clue
clue approved these changes Aug 25, 2022
View reviewed changes

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WyriHaximus

WyriHaximus commented Aug 25, 2022

Copy link
Copy Markdown
MemberAuthor

@clue:shipit: !

@WyriHaximus
WyriHaximus merged commit 9d496ba into reactphp:1.xAug 25, 2022
@clue
clue deleted the promise-3 branch August 25, 2022 09:32
This was referenced Sep 4, 2022
Merged
Merged
Merged
@clueclue mentioned this pull request Jul 7, 2023
Merged
@clueclue mentioned this pull request Aug 3, 2023
Merged
@clueclue mentioned this pull request Dec 22, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clueclueclue approved these changes

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

v1.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@WyriHaximus@clue