Wave A PR 1: CI + mypy strict + hygiene - #29

Merged
AndresL230 merged 9 commits into
mainfrom
wave-a/pr1-foundation
May 13, 2026
Merged

Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom
wave-a/pr1-foundation

Conversation

@AndresL230

@AndresL230AndresL230 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.

Closes#2, #13.

Test plan

  • CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)

🤖 Generated with Claude Code

@coderabbitai

coderabbitaiBot commented May 13, 2026•
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716

📥 Commits

Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.

📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wave-a/pr1-foundation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
Merged
Merged
AndresL230and others added 9 commits May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed the wave-a/pr1-foundation branch from ab2ab9e to 67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230 merged commit cc39d3b into mainMay 13, 2026
4 of 5 checks passed
@AndresL230AndresL230 mentioned this pull request May 14, 2026
Merged
1 task
@AndresL230
AndresL230 deleted the wave-a/pr1-foundation branch May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean

1 participant

@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Wave A PR 1: CI + mypy strict + hygiene - #29
Merged
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
May 13, 2026
Merged
Wave A PR 1: CI + mypy strict + hygiene#29
AndresL230 merged 9 commits into
mainfrom 
wave-a/pr1-foundation
Conversation
@AndresL230
@AndresL230AndresL230
commented
May 13, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Adds .github/workflows/ci.yml running ruff + mypy + pytest on Python 3.9–3.12.
  • Fixes all mypy strict errors so the public posture in README is true.
  • Drive-by hygiene: removes unused imports, replaces raise exc with bare raise to preserve tracebacks.
Closes#2, #13.
Test plan
  •  CI matrix green on 3.9, 3.10, 3.11, 3.12
  • mypy recost/ reports 0 errors locally
  • ruff check recost/ tests/ reports 0 errors locally
  • pytest passes locally (one pre-existing test failure unrelated to this PR)
🤖 Generated with Claude Code
@coderabbitai
coderabbitaiBot
commented
May 13, 2026•

edited

Loading

Copy link


Copy Markdown

Warning
Rate limit exceeded
@AndresL230 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 5 seconds before requesting another review.
You’ve run out of usage credits. Purchase more in the billing tab.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 63977f61-3b6b-40fb-98de-e111a0a2a716
📥 Commits
Reviewing files that changed from the base of the PR and between edf8b23 and 67a7e74.
📒 Files selected for processing (16)
  • .github/workflows/ci.yml
  • docs/superpowers/plans/2026-05-13-wave-a-production-readiness.md
  • docs/superpowers/specs/2026-05-13-wave-a-production-readiness-design.md
  • pyproject.toml
  • recost/_aggregator.py
  • recost/_interceptor.py
  • recost/_provider_registry.py
  • recost/_transport.py
  • recost/_types.py
  • recost/frameworks/fastapi.py
  • recost/frameworks/flask.py
  • tests/test_aggregator.py
  • tests/test_fastapi.py
  • tests/test_init.py
  • tests/test_scaffold.py
  • tests/test_transport.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch wave-a/pr1-foundation
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced May 13, 2026
 Merged

 Merged

AndresL230and others
added 9 commits
May 13, 2026 16:01
@AndresL230@claude
Add Wave A production-readiness design spec
a1fc137
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs:
foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety,
reentrancy guard), and transport & validation (auth escalation, 429 handling,
api_key validation, body-size fixes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
Add Wave A implementation plan
a0afa37
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy +
hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard),
PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation
+ body sizing).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
ci: add ruff + mypy + pytest matrix on Python 3.9-3.12
bbda447
@AndresL230@claude
fix(types): annotate to_dict returns as dict[str, Any] for mypy strict
2f6b8e0
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix(interceptor): mypy strict — type wrappers, latency_ms float, drop…
c37e6c3
… dead type-ignores
- RawEvent.latency_ms: int → float (latency is naturally fractional)
- MetricEntry.total/p50/p95_latency_ms: int → float to match
- _Bucket.latencies: List[int] → List[float]; _compute_percentile updated
- _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for
lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs
- _patched_send, _patched_async_send, _patched_request: explicit Any signatures
- Replace # type: ignore[no-untyped-def] with proper signatures throughout
- Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on
all method-assignment patching lines (urllib3, httpx, aiohttp)
- Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp
ship with inline types when installed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230@claude
fix: clean remaining mypy/ruff issues across recost/
d556c8b
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@AndresL230
fix(interceptor): use bare 'raise' to preserve traceback context (#13)
170b55a
@AndresL230@claude
fix: remove unused exception variables in _interceptor.py
9263bbf
Replace `except Exception as exc:` with bare `except Exception:` in four
locations where the exception is immediately re-raised. This preserves
the original traceback while satisfying ruff's F841 (unused variable) check.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230@claude
fix: post-rebase cleanup of unused imports and stale type-ignore
67a7e74
Wave 1 changes brought back unused imports (time/pytest in test_init.py,
MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed
websockets import. CI now passes on the rebased branch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AndresL230
AndresL230force-pushed
the
wave-a/pr1-foundation
branch
from
ab2ab9e to
67a7e74CompareMay 13, 2026 20:07
@AndresL230
AndresL230
merged commit cc39d3b
into
mainMay 13, 2026

4 of 5 checks passed

@AndresL230AndresL230
mentioned this pull request
May 14, 2026
 Merged

1 task
@AndresL230
AndresL230
deleted the

wave-a/pr1-foundation

branch
May 21, 2026 04:17
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

35 mypy strict errors — README claims strict-clean


1 participant

@AndresL230