Uh oh!
There was an error while loading. Please reload this page.
Wave A PR 2: fork-safety + reentrancy correctness - #30
Merged
Conversation
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (21)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 tasks
Covers issues #2, #3, #8, #13, #14, #15, #17, #18 across three sequenced PRs: foundation (mypy + CI + hygiene), lifecycle & correctness (fork-safety, reentrancy guard), and transport & validation (auth escalation, 429 handling, api_key validation, body-size fixes). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Three-PR sequence with bite-sized TDD tasks. PR 1 foundation (CI + mypy + hygiene), PR 2 lifecycle (RecostError base + fork-safety + reentrancy guard), PR 3 transport (typed errors + 401 escalation + 429 deferral + key validation + body sizing). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… dead type-ignores - RawEvent.latency_ms: int → float (latency is naturally fractional) - MetricEntry.total/p50/p95_latency_ms: int → float to match - _Bucket.latencies: List[int] → List[float]; _compute_percentile updated - _patched_urlopen: explicit Any-annotated signature, _UNSET sentinel for lazy timeout resolution, remove dead pool_connections/pool_maxsize kwargs - _patched_send, _patched_async_send, _patched_request: explicit Any signatures - Replace # type: ignore[no-untyped-def] with proper signatures throughout - Replace # type: ignore[attr-defined] with # type: ignore[method-assign] on all method-assignment patching lines (urllib3, httpx, aiohttp) - Remove now-stale # type: ignore[import-untyped] comments (urllib3/aiohttp ship with inline types when installed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace `except Exception as exc:` with bare `except Exception:` in four locations where the exception is immediately re-raised. This preserves the original traceback while satisfying ruff's F841 (unused variable) check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Wave 1 changes brought back unused imports (time/pytest in test_init.py, MAX_BUCKETS in _transport.py) and a stale type-ignore on the typed websockets import. CI now passes on the rebased branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…very Stores a _rebuild callable on RecostHandle that recreates the transport and flush-timer thread in the current PID; supports post-fork recovery. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nit (#3) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
#3) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace single ContextVar guard with dual mechanism: ContextVar for async-task scope, threading.local for same-thread recursion, and a threading.Thread.__init__ patch to propagate the guard ContextVar into child threads so cross-thread double-counting is prevented. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…uard Removes _original_thread_init, _patch_thread(), and _unpatch_thread() which injected a context= kwarg into threading.Thread.__init__ — this kwarg only exists on Python 3.14 and breaks CI on 3.9–3.12. The ContextVar + threading.local dual guard is retained; asyncio.to_thread already propagates contextvars on all supported Python versions (3.9+), which is the actual failure mode from issue #15. Updates test_reentrancy.py to test the asyncio.to_thread path and same-thread recursion guard rather than the raw Thread() path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AndresL230force-pushed
the
wave-a/pr2-lifecycle
branch
from
May 13, 2026 20:14
5e68d61 to
7864067CompareUh oh!
There was an error while loading. Please reload this page.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.register_at_fork(after_in_child=...)to automatically rebuild the timer thread, transport, and event loop in forked children. Addshandle.reinit_after_fork()for explicit reinit, plus a PID-mismatch backstop on the event path for platforms where the fork hook is unavailable (uwsgi lazy-fork, Windows, embedders).ContextVar) and the OS thread (threading.local), so calls that hop between async tasks and thread pools viaasyncio.to_threadorrun_in_executoraren't double-counted.RecostErrorbase class (subclasses follow in PR 3).Test plan
tests/test_fork_safety.pypasses — child process correctly rebuilds state afteros.fork()(POSIX-only, skipped on Windows).tests/test_reentrancy.pypasses —asyncio.to_threadpropagation; same-thread recursion guard.tests/test_errors.pypasses —RecostErrorimportable and subclasses Exception.test_has_21_rules.Closes#3 (fork-safety), #15 (reentrancy).
🤖 Generated with Claude Code