Uh oh!
There was an error while loading. Please reload this page.
[DI] Use entropy autodiscover() over registerTagged() for order-independent service collections - #8370
Merged
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
August 25, 2026 06:57
TomasVotruba
disabled auto-merge
August 25, 2026 06:58
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces four
registerTagged()calls inLazyContainerFactorywith entropy'sautodiscover(), which scans a directory and registers everything found. Shorter, and it drops four hand-maintained class-string constants plus their imports.Only the collections whose consumers are order-independent were converted, because
findByContract()returns services in registration order andautodiscover()uses filesystem (readdir) order, not the curated constant order:NodeTypeResolverInterfaceOutputFormatterInterfacegetName()ClassNameImportSkipVoterInterfacearray_any(any voter)ConverterAttributeDecoratorInterfaceFirst-match collections (
TypeMapperInterface,PhpDocTypeMapperInterface,PhpParserNodeMapperInterface,NodeNameResolverInterface,AnnotationToAttributeMapperInterface) keepregisterTagged()— their curated order is significant and must not depend on the filesystem.Verified each converted contract still resolves the exact same service count after boot (4 / 12 / 7 / 2).