Uh oh!
There was an error while loading. Please reload this page.
[DI] Convert two more order-independent collections to autodiscover - #8371
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8370. Converts two more collections from
registerTagged()toautodiscover().Both were previously held back as "order-sensitive", but verification shows their consumers match mutually exclusively — no input can match two entries — so filesystem registration order is irrelevant:
NodeNameResolverInterfaceis_a($node, $resolver->getNode())PhpDocTypeMapperInterfaceis_a($typeNode, $mapper->getNodeType())implements TypeNode, none extends anotherThe remaining
registerTagged()collections stay put because their matches do overlap and curated order is significant:TypeMapperInterface—ConstantArrayType extends ArrayTypePhpParserNodeMapperInterface—FullyQualified extends NameAnnotationToAttributeMapperInterface—String(is_string) is a superset ofClassConstFetch(is_string && '::')Both interfaces added to the class-leak skip list (their implementors are now discovered, not referenced). Verified each collection still resolves the same service count after boot (10 / 4), with no regression on the untouched collections (29 / 12).