Skip to content

chore: upgrade fullsend review harness - #181

Merged
kadel merged 1 commit into
redhat-developer:mainfrom
gashcrumb:chore/fullsend-v0.42-sonnet-review
Sep 9, 2026
Merged

kadel merged 1 commit into
redhat-developer:mainfrom
gashcrumb:chore/fullsend-v0.42-sonnet-review

Conversation

@gashcrumb

Copy link
Copy Markdown
Member

Upgrades Fullsend from v0.41.0 to v0.42.0. Uses a derived review harness with Sonnet and the upstream 45-minute review budget, resolving reviews that timed out before producing agent-result.json.

Assisted-By: OpenCode

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@gashcrumb
gashcrumb requested a review from kadel September 8, 2026 15:39
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 8, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:40 PM UTC · Completed 3:54 PM UTC

Commit: 690bef8 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.06

@gashcrumb

Copy link
Copy Markdown
Member Author

This change should fix this kind of behavior and probably also we can get away with sonnet instead of opus for code reviews.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 8, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Small CI/config change (4 files, 11 lines) with two protected-path changes (.github/ workflows) and CI workflow modifications, offset by minimal churn, single-author history, and no dependency or security-sensitive file changes.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml — PR modifies files under the .github/ protected path. No linked issue provides authorization for the change. Human approval is required for protected-path changes.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@kadel
kadel merged commit 968ad8a into redhat-developer:main Sep 9, 2026
50 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 9, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 8:12 AM UTC · Completed 8:25 AM UTC

Commit: 690bef8 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.16

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #181 — Upgrade fullsend review harness

PR #181 by gashcrumb upgraded fullsend from v0.41.0 to v0.42.0 and added a derived review harness (.fullsend/harness/review.yaml) switching from Opus to Sonnet with a 45-minute timeout. The change was motivated by PR #176, where the review agent timed out twice — spending 40+ minutes analyzing a large feature PR with Opus without producing output.

Workflow timeline

  1. PR opened (Sep 8, 15:38 UTC) — 4 files, +9/−2 lines
  2. Review agent ran (run 34246111426, 15:39–15:54 UTC, ~15 min, $3.06 with Opus) — used the pre-merge config since the harness changes weren't merged yet
  3. Review finding: protected-path flag on .github/workflows/fullsend.yaml and .github/workflows/prioritize.yml — no linked issue authorizing changes to .github/ paths. Verdict: CHANGES_REQUESTED
  4. Human review (kadel, Sep 9 08:11 UTC) — approved and merged, understanding the protected-path concern was procedural for a routine version bump

Key finding: Sonnet model not available on Vertex AI

After PR #181 merged, the first review using the new config (on PR #176, run 34327800934) failed immediately with: "The model claude-sonnet-4-6 is not available on your vertex deployment. Try --model to switch to claude-sonnet-4-5@20250929." The model: sonnet alias resolved to claude-sonnet-4-6, which is not provisioned on this repo's GCP Vertex AI deployment. This means all reviews on this repo are currently broken until the config is corrected. One proposal filed.

What went well

  • The review agent correctly identified the protected-path concern and appropriately requested human approval for CI workflow changes
  • The human reviewer understood the context and approved without unnecessary back-and-forth
  • The PR was well-scoped with a clear motivation linked to a specific prior failure
  • The derived harness pattern (pinned base + local overrides) is a clean configuration approach

No duplicates found

No existing issues in redhat-developer/rhdh-cli or fullsend-ai/fullsend cover the model availability finding.

Proposals filed

gashcrumb pushed a commit that referenced this pull request Sep 9, 2026
)

The model: sonnet alias in the review harness config resolved to
claude-sonnet-4-6, which is not provisioned on the repo's GCP
Vertex AI endpoint. This caused all review runs to fail immediately
with zero tokens used since PR #181 merged.

Pin the model to claude-sonnet-4-5@20250929, which the error
message in run 34327800934 confirmed is available on the deployment.
Using an explicit version avoids future breakage if the sonnet
alias advances again before the deployment is updated.

Note: yarn lint:check and yarn prettier:check could not run
(yarn not available in sandbox). The change is a single-line YAML
config update that is not covered by ESLint or Prettier.

Closes #187

Assisted-by: claude-opus-4-6

Co-authored-by: fullsend-code <278716306+fullsend-ai-coder[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants