Skip to content

fix(fullsend): use the correct model identifier - #191

Closed
gashcrumb wants to merge 1 commit into
redhat-developer:mainfrom
gashcrumb:switch-fullsend-model
Closed

gashcrumb wants to merge 1 commit into
redhat-developer:mainfrom
gashcrumb:switch-fullsend-model

Conversation

@gashcrumb

Copy link
Copy Markdown
Member

This change updates the review agent config to use the suggested model identifier for Claude Sonnet.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED

This change updates the review agent config to use the suggested model
identifier for Claude Sonnet.

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure (validation failed after 1 iteration(s)) · Started 10:49 AM UTC · Completed 10:51 AM UTC

Commit: c52b047 · View workflow run →

Runtime: claude · Model: claude-sonnet-4-5@20250929 · Effort: high

@gashcrumb gashcrumb closed this Sep 9, 2026
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 9, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 10:55 AM UTC · Completed 11:06 AM UTC

Commit: c52b047 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.04

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #191 — fix(fullsend): use the correct model identifier

Timeline

  1. PR chore: upgrade fullsend review harness #181 introduced .fullsend/harness/review.yaml with model: sonnet.
  2. Issue Review harness model sonnet resolves to unavailable claude-sonnet-4-6 on Vertex AI #187 (08:25 UTC, retro-generated): The sonnet alias resolved to claude-sonnet-4-6, unavailable on the repo's Vertex AI endpoint. All automated reviews broken.
  3. Triage agent (08:26–08:30 UTC, $0.69): Rated severity High, recommended changing to claude-sonnet-4-5@20250929.
  4. Code agent (08:31–08:35 UTC, $0.82): Created PR #188, pinning model to claude-sonnet-4-5@20250929. CI failed because the title fix(#187): contained # in the scope, violating the repo's headerPattern regex.
  5. Human intervention (~10:08 UTC): Stan Lewis renamed PR fix: pin review harness model to available Vertex AI version #188's title to remove the invalid scope character. PR fix: pin review harness model to available Vertex AI version #188 merged.
  6. Issue Document PR title scope character restrictions in AGENTS.md #189 (retro-generated, still OPEN): Filed to document PR title scope character restrictions in AGENTS.md.
  7. PR fix(fullsend): use the correct model identifier #191 (10:47 UTC, human-authored by Stan Lewis): Attempted to change model from claude-sonnet-4-5@20250929 to claude-sonnet-4@20250514 — the model the Vertex AI error message actually recommends.
  8. Review agent failure (10:48–10:51 UTC): The review agent tried to use claude-sonnet-4-5@20250929 (from base branch config) and failed immediately — zero tokens used, no output produced. Validation failed.
  9. PR fix(fullsend): use the correct model identifier #191 closed (10:54 UTC): Closed without merge.

Key Findings

The code agent's fix in PR #188 was incorrect. It pinned to claude-sonnet-4-5@20250929, which is also unavailable on Vertex AI. The Vertex AI error message explicitly suggests claude-sonnet-4@20250514, but the retro agent that filed issue #187 recommended a different (wrong) model, and the triage and code agents followed that recommendation without verification. The review agent has been broken on every PR since PR #188 was merged.

Chicken-and-egg problem. PR #191 attempted to fix the review agent's model config, but the review agent reads config from the base branch — which has the broken model. The review agent cannot review its own config fix.

Evidence for existing issues (skipped as proposals)

Proposals filed

Proposals skipped (target repo not allowed)

File manually or update create_issues.allow_targets in config.yaml:

  • Retro agent recommended unavailable model — should extract suggestion from error output (fullsend-ai/agents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant