Uh oh!
There was an error while loading. Please reload this page.
Add Tests for Doc Examples - #184
Merged
Merged
Conversation
aspeddro
marked this pull request as ready for review
January 22, 2024 01:02
zth
commented
Jan 22, 2024
Member
Very nice! A few notes/thoughts:
An alternative approach that perhaps could solve the above issues could be to:
What do you think? |
aspeddro
marked this pull request as draft
February 11, 2024 03:22
aspeddroforce-pushed
the
add-examples-tests
branch
from
February 18, 2024 22:30
c0d43cc to
3c4f07dCompareaspeddro
marked this pull request as ready for review
February 19, 2024 00:09
aspeddro
marked this pull request as draft
February 19, 2024 06:11
aspeddroforce-pushed
the
add-examples-tests
branch
from
February 21, 2024 03:00
041b3fa to
f3af423Compareaspeddro
marked this pull request as ready for review
February 21, 2024 03:06
ContributorAuthor
zth
approved these changes
Feb 23, 2024
zth
left a comment
Member
There was a problem hiding this comment.
This is great! We can refactor the script later on if we want, for now this works well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.