Uh oh!
There was an error while loading. Please reload this page.
add docstrings compiler tests - #7184
Conversation
cknitt
left a comment
There was a problem hiding this comment.
Wow, thanks a lot @aspeddro, I had completely overlooked this PR!
Regarding adding assert_eq to Pervasives, I think we should use follow ReScript naming conventions rather than OCaml naming conventions, i.e., use assertEqual rather than assert_eq.
I am also wondering if all those assertions look nice enough in the doc comments / hover help in VS Code, or whether we could maybe separate them somehow so that they are executed in the tests, but not shown in hover help.
Any thoughts on that @zth?
Uh oh!
There was an error while loading. Please reload this page.
| let runtimeErrors = | ||
| (await compiled | ||
| ->Array.filter((({id}, _, _)) => !Array.includes(ignoreRuntimeTests, id)) | ||
| ->Array.map(async ((example, rescriptCode, jsCode)) => { |
There was a problem hiding this comment.
If there is too much parallelism here, you might consider a solution like in #7081.
cknitt
commented
Jan 5, 2025
Superseded by #7219. |
Add tests for docstrings examples
From rescript-lang/rescript-core#184
We can extend this PR to add runtime tests (rescript-lang/rescript-core#210)