Honour "keep the one on disk", and finish Phase 7

[revtex]

Fixes a settings bug that silently did the opposite of what it said, and closes out Phase 7.

"Keep the one on disk" was overwriting

The existing-file policy was checked the instant a track changed — before the metadata lookup returned anything. For any template that names an album, that is the wrong path:

{artist}\({year}) {album}\{track:00} {title}

renders as Artist\Title.mp3 while {year}, {album} and {track} are still empty. The check looked somewhere nothing is ever written, found nothing every time, and let the recording proceed to a destination RenameFile then replaced without a word. For anyone whose template is more than artist and title, "Keep the one on disk" behaved as "Overwrite".

The authoritative check moves into TrackRecorder.AlreadyOnDisk, after enrichment and before the encode — the first point at which the destination is knowable, and early enough not to spend an ffmpeg run on a file about to be discarded. The early check stays as a shortcut for the simple templates it can still answer honestly, and OnEncodeCompleted keeps a last gate for two encodes of the same track racing.

Generalisable: a decision taken against a track that has not been enriched is a decision taken against different data than the one that writes the file.

The policy never said what it did

Overwriting and adding a counter both look exactly like an ordinary save from the outside, which is what kept the bug above invisible — there was no way to tell a setting that was broken from one working silently. All three outcomes now name themselves and the file:

• Kept the file already on disk and discarded this recording of …: <path>
• Saved …, replacing the file already there.
• Saved …; the name the template asked for was taken.

VB-CABLE, surfaced

Reported beside the device picker rather than in a section of its own — the cable is one more endpoint to record, not a mode. Both states get a line: a user who installed it and cannot find it in the dropdown is told it is there; a user without it is told that recording an ordinary output device captures every sound the machine makes. Detection runs off the same list the dropdown was built from, so the two can never disagree, and re-runs on the refresh button. The link goes to vb-audio.com — Offstream still ships no vendor binaries (open question 9).

Switch rows

The label column had been pinned to a fixed width to keep each switch near its label. The effect was the opposite: a column of switches stranded mid-card, and every label longer than the pin broken across two and three lines. Labels now take the room and the switches sit on the card's right margin, one line each, ellipsised with a tooltip below the width where that stops fitting. The recording timer's duration field moved to the left of its switch so that switch stays in line with the others.

Clean-VM pass dropped from Phase 7

It was written to catch downlevel Windows 10 differences in the interop, the SMTC session manager and the endpoint notifications. Windows 11 only removes the question it existed to answer, and the development machine is the supported OS. Phase 8's clean-VM install → record → update → uninstall run is a different question and stays.

Phase 7 is complete.CLAUDE.md and the plan updated accordingly.

Testing

805 Core tests green, dotnet format --verify-no-changes clean. Per standing instruction the UI suite is left to manual testing; three SettingsViewModel tests covering the cable notice are included but not run here.

🤖 Generated with Claude Code