Changelog: catch up on PRs 12-23, and require an entry per PR - #24
Merged
Conversation
It was last touched in #11 and ten PRs have merged since, so the file described an app several phases behind the one in the tree - which for a Keep a Changelog file is worse than an empty one, because it reads as current. Entries for: the refresh token lost an hour into every session, SMTC as the primary track source and the TFM raise that allows it, endpoint hot-plug, extended-length paths, VB-CABLE detection, the existing-file policy checked before it could know the destination, the Logs tab and the Record page rework, the Spotify match guard, genre from Spotify's artists with Last.fm behind it, the media-session floor and its two mappers, Last.fm's missing album guard, the shutdown that left a ghost process, and the provider summaries on Settings. Readiness is deliberately absent: it was added in #18 and removed in #19, so no release ever carried it and an entry for each would be two lines describing nothing. Test count updated to 1051 (877 Core, 174 UI). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The changelog going ten PRs stale was not an oversight anyone would catch by trying harder, so it is a rule with a check behind it now rather than a good intention. CLAUDE.md states it; a CI job fails a pull request whose diff does not touch CHANGELOG.md, with a `no-changelog` label as the escape hatch so a test-only fix opts out by saying so instead of by staying quiet. The job runs on ubuntu with no `needs`, so it answers in seconds alongside the Windows build rather than behind it - which is why it is a job of its own, despite the note on `build` arguing against exactly that for publish-check. That case was gated on `needs: build` and paid for a second VM to run strictly afterwards; this one does not. Also removes 06aa2f03-...jpg and b514cfc3-...jpg from the repository root. Both were untracked, and both were mine to be suspicious of and wrong about: I guessed earlier they were leaked cover-art downloads. They are not. CoverArtFetcher writes to GetTempPath() under the name "<random>.offstream-cover.jpg" and never to the working directory, and these were a matched pair of 1024x572 images, which is not the shape album art comes in. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwas last touched in #11. Ten PRs have merged since — #12, #13, #15, #16, #17, #18, #19, #20, #22, #23 — and none of them updated it, so the file described an app several phases behind the one in the tree. For a Keep a Changelog file that is worse than an empty one, because it reads as current.Entries are written from the merged commit messages rather than the PR titles, and follow the file's existing convention of describing the defect rather than the patch.
Added
Endpoint hot-plug, extended-length paths, VB-CABLE detection, the Logs tab, the saved-this-session panel and per-track art/album/destination, genre from Spotify's artists with Last.fm behind it, the album track total from the media session, and the provider summaries on Settings.
Changed
The TFM raise to
net10.0-windows10.0.22621.0and why SMTC needs it, the media session as primary track source, metadata precedence (provider first, media session underneath), and the two Record/Advanced page reworks.Fixed
The refresh token lost an hour into every session,
InMemoryLogSinkdiscarding exceptions, "keep the one on disk" behaving as overwrite, the Spotify match comparing a parsed string against an unparsed one, Last.fm's missing album guard and its untouched artist tags, the media-session data discarded when a provider could not help, the shutdown that left a ghost process, the double-logged failures, the cover-art failure filed below the Problems filter, and the stale saved-count string.Deliberately absent
Readiness. Added in #18, removed in #19 — no release ever carried it, so an entry for each would be two lines describing nothing.
The Spotify attribution line. Added and removed within the same unreleased cycle, and the
Removedsection in this file is written against the predecessor rather than against Offstream's own history.Test count updated to 1051 (877 Core, 174 UI). Docs only — no code touched.
🤖 Generated with Claude Code