Metadata correctness, a stoppable shutdown, and the logging audit

[revtex]

Started as "print the genre tag in the activity log" and grew each time the log revealed something real. Ten commits in four groups.

1. Logging audit

Every recording failure was printed twice.RaiseFailed put the message on the Failed event and on the progress report beside it — logged at Error and at Information, so each failure appeared twice with identical text, once in a colour meaning act on this and once meaning carry on. The report still fires (it moves the display back to waiting); it no longer narrates.

A cover-art failure was filed as news. It went out as a progress message, landing at Information — below the Problems filter, invisible to anyone looking for exactly this. Now a Warning, logged directly, because a progress message cannot carry a level.

Silence filled. The artist-genre lookup (asked / cached / no artist id), and the ffmpeg argv before each run, all at Debug. Ogg and Opus keep cover art where -show_format cannot see it, so a silent success was indistinguishable from a silent skip.

Genre attribution. The "tagged" line now carries genre and names the source when it was not the provider already named:

Spotify tagged Artist - Title: album Album Name, track 4, genre trance, eurodance.
Spotify tagged Artist - Title: album Album Name, track 4, genre trip hop (LastFm).

"none" rather than the "unknown" album and position use: those are missing from a reply that was received, while an empty genre means every source was asked and none had one.

2. Last.fm correctness

Genres exist where nobody was asking. Last.fm frequently has no tags for a recording while carrying a rich set for its performer, and the lookup stopped at the empty track answer. It now falls through to artist.getTopTags, cached per artist for the session. ATB's "9Pm (Till I Come)" is the case that prompted it — no track tags, three good artist tags.

Last.fm as the chosen provider was doing less than as the fallback. Its own path only mapped anything when an album came back too, so a track whose tags were sitting there got none.

No match guard at all.track.getInfo returns whichever release its community database associates, which for a well-known track is regularly a DJ set or radio show. Nothing checked it — Spotify has DetectedTrackMatch, Last.fm had nothing, so whatever came back was written. ATB's track was tagged with a radio show's tracklist over the "Movin' Melodies" the media session had already reported. DetectedTrackMatch.AlbumAgrees now compares the two, treating an edition suffix as more said about the same record. A rejected release still yields its genre — tags describe the recording, not the release.

3. The media-session floor

AlbumTrackCount was reported by SMTC and never read, so the 5/12 track tag needed a configured provider even though the client had volunteered both numbers. The Spotify mapper's AlbumTrackCount and the Last.fm mapper's AlbumArtists both overwrote rather than filled — the second would replace a session-reported "Various Artists" with whoever performed one track.

4. Shutdown, and saying what the providers do

Closing the window mid-recording left a ghost process, killable only from Task Manager. Three defects, each hiding the next:

• OnExit was async void, which WPF does not await. It ran to its first await, returned, and let Application.Run tear the Dispatcher down — so the continuation carrying the rest of the shutdown was posted to a Dispatcher that would never run it. The host was never stopped, the capture client never closed, the backlog never drained, and CloseAndFlushAsync never ran, which is why this left nothing in the log to read.
• using (_host) disposed the container synchronously. RecordingController is a singleton implementing IAsyncDisposableonly, and ServiceProvider.Dispose() throws on such a service rather than falling back — so the one call that stops the session threw, at the moment it most needed to work.
• Nothing bounded the drain. EncodeBacklog.CompleteAsync takes no deadline. Thirty seconds now: generous, because a queued encode is a file the user is waiting for; finite, because closing Offstream has to end Offstream.

"Nothing — use the window title only" had been wrong since the media session became the detection source, and the dropdown said nothing about how the three providers differ. Each now carries a summary of what it adds — none of them is the floor. The difference that matters most is the least visible: only Spotify carries a release date, so {year} is empty under the others.

The standalone Spotify attribution line is removed as overclaiming; the provider summary names Spotify as the source of what it does supply, in the same place.

Verified, not assumed

• Last.fm cannot supply a release year: releasedate comes back empty and published is a wiki edit timestamp (2024 on a 1999 album).
• SMTC has no date property at all — the full member list is AlbumArtist, AlbumTitle, AlbumTrackCount, Artist, Genres, PlaybackType, Subtitle, Thumbnail, Title, TrackNumber.
• NAudio sets IsBackground = true on both its capture and playback threads, so neither was what held the process up. The exact handle was never identified — no hung process survived to inspect — which is why the shutdown is bounded and logs on expiry.

Tests

1051 green (877 Core + 174 UI). dotnet format --verify-no-changes clean.

🤖 Generated with Claude Code