Make sure to include-what-you-use in the node_interfaces. - #2018
Merged
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
alsora
approved these changes
Sep 29, 2022
delete-merged-branch
Bot
deleted the
clalancette/rclcpp-node-interface-includes
branch
September 29, 2022 11:54
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Jul 19, 2023
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Z572
added a commit
to revyos-ros/rosdistro
that referenced
this pull request
Jun 3, 2024
bartalor
pushed a commit
to bartalor/rclcpp
that referenced
this pull request
Jul 15, 2026
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
nim65s
added a commit
to nim65s/rclcpp
that referenced
this pull request
Jul 22, 2026
fix play_motion2 on nix:
```cpp
[ 60%] Built target ament_cmake_python_build_play_motion2_egg
In file included from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.hpp:23,
from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.cpp:19:
/nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:42:10: error: 'function' in namespace 'std' does not name a template type
42 | std::function<
| ^~~~~~~~
/nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:30:1: note: 'std::function' is defined in header '<functional>'; this is probably fixable by adding '#include <functional>'
29 | #include "rclcpp/parameter.hpp"
+++ |+#include <functional>
30 | #include "rclcpp/visibility_control.hpp"
```
already fixed in rolling: ros2#2018
Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
ahcorde
pushed a commit
that referenced
this pull request
Jul 23, 2026
fix play_motion2 on nix:
```cpp
[ 60%] Built target ament_cmake_python_build_play_motion2_egg
In file included from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.hpp:23,
from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.cpp:19:
/nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:42:10: error: 'function' in namespace 'std' does not name a template type
42 | std::function<
| ^~~~~~~~
/nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:30:1: note: 'std::function' is defined in header '<functional>'; this is probably fixable by adding '#include <functional>'
29 | #include "rclcpp/parameter.hpp"
+++ |+#include <functional>
30 | #include "rclcpp/visibility_control.hpp"
```
already fixed in rolling: #2018
Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This may help the compile error we are seeing in ros2/geometry2#555 . Even if it doesn't, it is the right thing to do.