add missing header for std::function - #3211
Merged
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
fix play_motion2 on nix:
```cpp
[ 60%] Built target ament_cmake_python_build_play_motion2_egg
In file included from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.hpp:23,
from /build/play_motion2-release-release-humble-play_motion2-1.8.5-1/src/utils/motion_loader.cpp:19:
/nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:42:10: error: 'function' in namespace 'std' does not name a template type
42 | std::function<
| ^~~~~~~~
/nix/store/ifw8313yfmyarrgqscg249m9krx58sh2-ros-humble-rclcpp-16.0.19-r1/include/rclcpp/rclcpp/node_interfaces/node_parameters_interface.hpp:30:1: note: 'std::function' is defined in header '<functional>'; this is probably fixable by adding '#include <functional>'
29 | #include "rclcpp/parameter.hpp"
+++ |+#include <functional>
30 | #include "rclcpp/visibility_control.hpp"
```
already fixed in rolling: ros2#2018
Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
nim65s
force-pushed
the
humble-functional
branch
from
July 22, 2026 11:49
64dcb5d to
040b575
Compare
ahcorde
approved these changes
Jul 22, 2026
Contributor
|
Pulls: #3211
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix play_motion2 on nix:
Is this user-facing behavior change?
no
Did you use Generative AI?
no
Additional Information
already fixed in rolling: #2018, but still breaks when building humble with a recent compiler.