Skip to content

Integrate the JRuby extension - #25

Merged
knu merged 13 commits into
masterfrom
jruby_ext_integration
Sep 30, 2021
Merged

Integrate the JRuby extension#25
knu merged 13 commits into
masterfrom
jruby_ext_integration

Conversation

@knu

@knuknu commented Sep 28, 2021

Copy link
Copy Markdown
Member

This work is based on #21. Ruby engine specific parts now reside in their respective ext/* directories, while keeping the common parts in lib/.

@knuknu mentioned this pull request Sep 28, 2021
@eregon

Copy link
Copy Markdown
Member

👍 looks good to me.

@ahorek

Copy link
Copy Markdown

👍 LGTM

I don't think that the final java gemfile should be shipped with C sources - ext/digest/** and vice versa. But it's a detail.

@knu

knu commented Sep 28, 2021

Copy link
Copy Markdown
MemberAuthor

@ahorek You have a point. I added a commit to address that.

Comment threaddigest.gemspec Outdated
Comment threaddigest.gemspec Outdated
@knu
knuforce-pushed the jruby_ext_integration branch from e140ed1 to 2855e3eCompareSeptember 29, 2021 04:10
@knu

knu commented Sep 29, 2021

Copy link
Copy Markdown
MemberAuthor

I've squashed some commits. I think I can merge this later today. Thank you all for taking a look!

@nobu

nobu commented Sep 29, 2021

Copy link
Copy Markdown
Member

Some commits, CI changes and dropping ext/openssl, seem better to be separated from this issue.

@nobu

nobu commented Sep 29, 2021

Copy link
Copy Markdown
Member

I think that the @eregon's idea, mapping .so to .jar in JRuby, is better for other libraries too.

@eregon

Copy link
Copy Markdown
Member

I think that the @eregon's idea, mapping .so to .jar in JRuby, is better for other libraries too.

It would be good to get JRuby's feedback on that, I opened jruby/jruby#6865

@knu
knu merged commit 27ab6de into masterSep 30, 2021
@knu
knu deleted the jruby_ext_integration branch September 30, 2021 06:12
@ahorekahorek mentioned this pull request Oct 29, 2021
@hsbthsbt mentioned this pull request Dec 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@knu@eregon@ahorek@nobu