Uh oh!
There was an error while loading. Please reload this page.
Integrate the JRuby extension - #25
Conversation
eregon
commented
Sep 28, 2021
👍 looks good to me. |
ahorek
commented
Sep 28, 2021
👍 LGTM I don't think that the final java gemfile should be shipped with C sources - ext/digest/** and vice versa. But it's a detail. |
knu
commented
Sep 28, 2021
@ahorek You have a point. I added a commit to address that. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e140ed1 to
2855e3eCompareknu
commented
Sep 29, 2021
I've squashed some commits. I think I can merge this later today. Thank you all for taking a look! |
nobu
commented
Sep 29, 2021
Some commits, CI changes and dropping ext/openssl, seem better to be separated from this issue. |
nobu
commented
Sep 29, 2021
I think that the @eregon's idea, mapping |
eregon
commented
Sep 29, 2021
It would be good to get JRuby's feedback on that, I opened jruby/jruby#6865 |
This work is based on #21. Ruby engine specific parts now reside in their respective
ext/*directories, while keeping the common parts inlib/.