Uh oh!
There was an error while loading. Please reload this page.
Add new configuration to preserve headers case - #146
Open
AllanSiqueira wants to merge 8 commits into
Open
Conversation
AllanSiqueiraforce-pushed
the
preserve-headers-option
branch
from
August 16, 2023 12:44
844b130 to
b828e8fCompareAllanSiqueira
marked this pull request as ready for review
August 19, 2023 04:58
- Add new configuration to preserve headers case in Net::HTTP class - Add new configuration to preserve headers case in GenericRequest class
AllanSiqueiraforce-pushed
the
preserve-headers-option
branch
from
September 11, 2023 12:34
b828e8f to
7daa433Comparenobu
requested changes
Oct 30, 2023
nobu
left a comment
Member
There was a problem hiding this comment.
The name doesn’t feel nice to me.
What of headers does it preserve?
AllanSiqueira
commented
Oct 30, 2023
Author
Great, what do you think we call it |
nobu
commented
Nov 1, 2023
Member
It sounds fine. |
AllanSiqueiraforce-pushed
the
preserve-headers-option
branch
from
November 7, 2023 17:25
1424174 to
d688a13CompareAllanSiqueira
commented
Nov 16, 2023
Author
Done the changes, when you have the time, may you review it again @nobu ? |
moracca
commented
Oct 9, 2025
Is this branch still being considered? |
AllanSiqueira
commented
Oct 9, 2025
Author
I can update it, but I don't know if it will be merged, I'm waiting for a response from a maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #143