Uh oh!
There was an error while loading. Please reload this page.
Refactor Net::HTTP#connect - #172
Open
stanhu wants to merge 1 commit into
Open
Conversation
stanhuforce-pushed
the
sh-refactor-connect
branch
from
January 10, 2024 00:17
0061a7c to
ad76b37Comparestanhu
marked this pull request as draft
January 10, 2024 00:18
stanhu
commented
Jan 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
stanhuforce-pushed
the
sh-refactor-connect
branch
from
January 10, 2024 06:00
ad76b37 to
0c0da29CompareThe method was getting large, and in preparation for ruby#141, I thought it would be easier to break up the method into several other methods.
stanhuforce-pushed
the
sh-refactor-connect
branch
from
January 10, 2024 06:07
0c0da29 to
4fc12dbComparestanhu
marked this pull request as ready for review
January 10, 2024 06:08
stanhu
commented
Jan 10, 2024
Author
https://github.com/ruby/net-http/pull/147/files seems to have a similar refactoring. |
stanhu
commented
Jan 11, 2024
Author
@nurse What do you think about this change? |
stanhu
commented
May 24, 2024
Author
@nurse Could you review this? |
xlgmokha
commented
May 27, 2024
@hsbt, @nurse do you have time to review this change? This is related to a DNS rebinding issue that we are experiencing on gitlab.com that we are working to resolve. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method was getting large, and in preparation for #141, I thought it would be easier to break up the method into several other methods.