fix(specs): use MAX_SIGNERS in multisig initialize harness - #170
Closed
Stevengre wants to merge 1 commit into
Conversation
Author
|
Folded into #169 so the proof-only multisig implementation/layout change and the shared initialize harness bound stay in one review unit. Closing this PR as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the shared initialize-multisig harness's hardcoded
11bounds withspl_token_interface::instruction::MAX_SIGNERS.Context
Once the runtime-verification path switches to a 3-signer multisig layout, the shared initialize harness must use the same bound as the implementation. Keeping literal
11in the spec admits out-of-model branches that the proof-only implementation no longer allows.Red vs Green
Red:
MAX_SIGNERS = 3.1..=11, so impossible branches survive insidetest_process_initialize_multisig/test_process_initialize_multisig2.Green:
MAX_SIGNERSconstant.References
spl_token_interface::instruction::MAX_SIGNERSRangeInclusive::contains