fix(runtime-verification): align proof-only multisig bounds and layout - #169
Merged
automergerpr-permission-manager[bot] merged 10 commits intoMar 10, 2026
Conversation
automergerpr-permission-manager Bot
pushed a commit
to runtimeverification/mir-semantics
that referenced
this pull request
Mar 10, 2026
This PR makes the necessary changes in symbolic/p-token.md to have 3 `MAX_SIGNERS` instead of 11. It looks that this is something we are working towards (e.g., runtimeverification/solana-token#169, https://runtimeverification.slack.com/archives/C03QD0KTDMJ/p1772645076956859).
dkcumming
marked this pull request as ready for review
March 10, 2026 18:01
mariaKt
approved these changes
Mar 10, 2026
mariaKt
left a comment
There was a problem hiding this comment.
Looks good to me, just a minor comment. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This aligns the proof-only multisig contract under
runtime-verification: useMAX_SIGNERS = 3in the interface/layout, deriveMultisig::LENfromMAX_SIGNERS, propagate the feature fromprogramintospl-token-interface, and update the shared initialize-multisig harness to use the same proof-only signer bound.Context
The proof-only multisig work moved to a 3-signer profile to keep state growth bounded, but the contract was still split across layers. The interface crate encoded the normal 11-signer layout, while the shared initialize harness still admitted
1..=11. That left the runtime-verification implementation and its spec exploring different domains.Red vs Green
Red:
runtime-verificationbuilds still used the normal 11-signer interface layout (MAX_SIGNERS = 11,Multisig::LEN = 355).1..=11, so impossible branches survived insidetest_process_initialize_multisig/test_process_initialize_multisig2.Green:
runtime-verificationbuilds now useMAX_SIGNERS = 3.Multisig::LENis derived fromMAX_SIGNERS, so pack/unpack and account-size checks stay consistent.3), so the harness domain matches the proof-only implementation domain in both inclusion contexts.References
interface/src/instruction.rsinterface/src/state.rsprogram/src/instruction.rsprogram/src/entrypoint-runtime-verification.rsp-token/src/entrypoint-runtime-verification.rs