Uh oh!
There was an error while loading. Please reload this page.
Move unit tests into its own file - #204
Conversation
alexcrichton
commented
Jul 9, 2019
I'm not sure what the reason for this is? I personally think it's great to be able to write tests inline and have them executed. You're in general not really supposed to use |
The compiler-builtin crate uses |
Alternatively, we could properly In the long term, I would prefer these tests to move to the |
gnzlbg
commented
Jul 10, 2019
The last commit moves the musl reference tests and required functionality into its own file. |
alexcrichton
commented
Jul 10, 2019
It may be worthwhile to point out that I continue to not think that this change is worth it since it's more readable to have tests inline and I don't think there's a reason to move them out. |
This PR moves all unit tests into their own file so that they are not included when pulling the math module via a
#[path]import (like the one in compiler builtins, or in a crate that wants to build a cdylib).