Uh oh!
There was an error while loading. Please reload this page.
Properly test wasm32-unknown-unknown on CI - #206
Conversation
alexcrichton
commented
Jul 9, 2019
I don't think this is something we want to do on CI? Wasm is different enough that we don't really want to test all configurations exhaustively, we just want to make sure that it builds at all and doesn't hit codegen errors. The CI errors here for wasm are sort of just the start I'd imagine for getting the full suite running. |
4e01576 to
a9a76f3Comparegnzlbg
commented
Jul 10, 2019
So this is ready for now. Depending on whether #204 is merged or not, what would remain doing is using the |
gnzlbg
commented
Jul 11, 2019
So I've added use of I can workaround that here if you want, but the more tests we add directly into the libm crate, the more workarounds are going to be required in the I still think that, since this crate is only used by including it via I suppose we could add |
gnzlbg
commented
Jul 11, 2019
Note: the failures here are unrelated and due to rust-lang/rust#62574 , should be fixed in nightly soon. |
alexcrichton
commented
Jul 11, 2019
I'm personally not really super keen on merging this unfortunately. This seems to add a good deal of implementation complexity and infrastructure, which is just yet-again-more to keep working on CI. I don't think we really get any benefit from running these tests on wasm either, so I'm not really sure it's worth the weight of this PR to merge it? |
Currently not all configurations are build for wasm32, and the llvm intrinsics are incorrectly feature gated.