Skip to content

Don't create msi links for windows gnullvm targets - #975

Merged
Urgau merged 2 commits into
rust-lang:masterfrom
arnabanimesh:remove-gnullvm-msi-links
Nov 9, 2025
Merged

Don't create msi links for windows gnullvm targets#975
Urgau merged 2 commits into
rust-lang:masterfrom
arnabanimesh:remove-gnullvm-msi-links

Conversation

@arnabanimesh

@arnabanimesharnabanimesh commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Since msi installers for windows gnullvm targets are not being published, it should not be part of the documentation.

Ideally it would be better if there would be msi installers for these targets in my opinion though.

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @Urgau

rustbot has assigned @Urgau.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@apiraino

Copy link
Copy Markdown
Contributor

@arnabanimesh just to understand the context of this patch. The fact that the .msi Windows packages are not available for that target is intentional from us or is it something we should look into?

A bit more context in the description would be helpful for those (like me) in the project not extremely familiar about our releases artifacts. Thanks.

@arnabanimesh

Copy link
Copy Markdown
ContributorAuthor

@apiraino Added proper explanation in the description

@apiraino

Copy link
Copy Markdown
Contributor

I was curious so I asked: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/No.20Windows.20.2Emsi.20packages.20for.20targets.20.60-gnullvm.60/near/553825621

Please let's wait a sec before merging this.

@rustbot label S-blocked

@rustbotrustbot added the S-blocked Status: Blocked on something else such as a PR in another repository. label Nov 5, 2025
@Urgau

Urgau commented Nov 9, 2025

Copy link
Copy Markdown
Member

We have got an answer for why we don't yet produce .msi installers for the gnullvm targets, bc we cross-compile from Linux and cannot create an .msi installers from there.

Until that's done (cc rust-lang/rust#148751), I think we can move along, and when the situation changes we can revert this PR.

@rustbot label -S-blocked

@rustbotrustbot removed the S-blocked Status: Blocked on something else such as a PR in another repository. label Nov 9, 2025

@UrgauUrgau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bringing this up.

@Urgau
Urgau merged commit 355614e into rust-lang:masterNov 9, 2025
1 check passed
@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@arnabanimesh@rustbot@apiraino@Urgau