Skip to content

Revert "Don't create msi links for windows gnullvm targets" - #980

Merged
Urgau merged 4 commits into
rust-lang:masterfrom
arnabanimesh:revert-975-remove-gnullvm-msi-links
Nov 29, 2025
Merged

Revert "Don't create msi links for windows gnullvm targets"#980
Urgau merged 4 commits into
rust-lang:masterfrom
arnabanimesh:revert-975-remove-gnullvm-msi-links

Conversation

@arnabanimesh

@arnabanimesharnabanimesh commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Reverts #975

Since PR rust-lang/rust#148751 is merged, we can include msi installer links for windows gnullvm targets in the documentation now.

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 27, 2025
@rustbot

rustbot commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

r? @Urgau

rustbot has assigned @Urgau.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Urgau

Urgau commented Nov 27, 2025

Copy link
Copy Markdown
Member

Is there any way we could make the link conditional on the version (to avoid the link being present for stable and beta until rust-lang/rust#148751 reaches stable) ?

@arnabanimesh
arnabanimesh marked this pull request as draft November 29, 2025 01:02
@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2025
@arnabanimesh
arnabanimesh marked this pull request as ready for review November 29, 2025 02:12
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2025
@arnabanimesh

arnabanimesh commented Nov 29, 2025

Copy link
Copy Markdown
ContributorAuthor

@Urgau added the rust version check

Urgau
Urgau approved these changes Nov 29, 2025
View reviewed changes

@UrgauUrgau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Urgau
Urgau merged commit 8ac712d into rust-lang:masterNov 29, 2025
1 check passed
@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnabanimesh@rustbot@Urgau