Skip to content

Fixes bootstrap panic when running x fmt --check - #100339

Merged
bors merged 2 commits into
rust-lang:masterfrom
shourya5:issue#100258
Aug 10, 2022
Merged

Fixes bootstrap panic when running x fmt --check #100339
bors merged 2 commits into
rust-lang:masterfrom
shourya5:issue#100258

Conversation

@shourya5

Copy link
Copy Markdown
Contributor

closes#100258 wherein bootstrap panics when running x fmt --check. Fixed by replacing resume_unwind in #98994. with process::exit.

bootstrap panic when running x fmt --check.
running x fmt --check
@rustbotrustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 9, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@jyn514

Copy link
Copy Markdown
Member

@shourya5 have you tested this change locally?

@jyn514jyn514 assigned jyn514 and unassigned Mark-SimulacrumAug 10, 2022
@shourya5

Copy link
Copy Markdown
ContributorAuthor

@shourya5 have you tested this change locally?

Yes, it does run without throwing a panic on my system. @jyn514

@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 0d8bcc3 has been approved by jyn514

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2022
…mpiler-errors
Rollup of 8 pull requests
Successful merges:
- rust-lang#100286 (Add support for link-flavor rust-lld for macOS)
- rust-lang#100317 (Remove logic related to deprecated nvptx-nvidia-cuda (32-bit) target)
- rust-lang#100339 (Fixes bootstrap panic when running x fmt --check )
- rust-lang#100348 (Add regression test for rust-lang#93205)
- rust-lang#100349 (Refactor: remove a type string comparison)
- rust-lang#100353 (Fix doc links in core::time::Duration::as_secs)
- rust-lang#100359 (Special-case references to leafs in valtree pretty-printing)
- rust-lang#100371 (Inline CStr::from_bytes_with_nul_unchecked::rt_impl)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f0fdc46 into rust-lang:masterAug 10, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bootstrap panics when running x fmt --check

6 participants

@shourya5@rust-highfive@jyn514@bors@Mark-Simulacrum@rustbot