Skip to content

Add regression test for #93205 - #100348

Merged
bors merged 2 commits into
rust-lang:masterfrom
camelid:test-93205
Aug 10, 2022
Merged

Add regression test for #93205#100348
bors merged 2 commits into
rust-lang:masterfrom
camelid:test-93205

Conversation

@camelid

Copy link
Copy Markdown
Member

Closes#93205.

This issue was most likely fixed by #93805.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 9, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@rust-log-analyzer

This comment has been minimized.

@jyn514jyn514 assigned jyn514 and unassigned Mark-SimulacrumAug 10, 2022
@jyn514jyn514 added the A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name label Aug 10, 2022
This issue was most likely fixed by rust-lang#93805.
@rust-log-analyzer

This comment has been minimized.

@camelid

camelid commented Aug 10, 2022

Copy link
Copy Markdown
MemberAuthor

Quoting from my most recent commit:

For some reason, adding some text to match against makes this test pass.
Before, when it was more general, it was failing!

This seems very likely to be a bug in htmldocck, which I'm going to
investigate.

For some reason, adding some text to match against makes this test pass.
Before, when it was *more* general, it was failing!
This seems very likely to be a bug in htmldocck, which I'm going to
investigate.
@camelid

Copy link
Copy Markdown
MemberAuthor

Ok, so it looks like @has FILE PATTERN treats PATTERN as literal text, while @has FILE PATTERN ANOTHER_PATTERN treats PATTERN as an XPath (and ANOTHER_PATTERN as literal text). This seems quite confusing. I feel like we should have a different name for these two versions. Like @hasliteral.

@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 7bfcfd2 has been approved by jyn514

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2022
…mpiler-errors
Rollup of 8 pull requests
Successful merges:
- rust-lang#100286 (Add support for link-flavor rust-lld for macOS)
- rust-lang#100317 (Remove logic related to deprecated nvptx-nvidia-cuda (32-bit) target)
- rust-lang#100339 (Fixes bootstrap panic when running x fmt --check )
- rust-lang#100348 (Add regression test for rust-lang#93205)
- rust-lang#100349 (Refactor: remove a type string comparison)
- rust-lang#100353 (Fix doc links in core::time::Duration::as_secs)
- rust-lang#100359 (Special-case references to leafs in valtree pretty-printing)
- rust-lang#100371 (Inline CStr::from_bytes_with_nul_unchecked::rt_impl)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a6116b9 into rust-lang:masterAug 10, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 10, 2022
@camelid
camelid deleted the test-93205 branch August 28, 2022 20:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intradoc Self:: links are "not in scope" when used in impl blocks across modules

7 participants

@camelid@rust-highfive@rust-log-analyzer@jyn514@bors@Mark-Simulacrum@rustbot